Keymaps #1509

ppot · 2017-02-15T00:17:53Z

Keymaps Feature

On this implementation, I included a base of Keymap following three specific files.

darwin.json
win32.json
linux.json

This way, the Keymap will be easier to manage using accelerator. Since we want the Keymap to be easily modified and not forcing the remplacement of metaKey depending of the operating system.

New file structure

.hyper/config.js
.hyper/plugins
.hyper/local

New DEV structure

You can now do development when running Hyper locally and the DEV folder will not be created in the production build

config will be at .hyper/DEV/config.js

Resolve

#233 Tmux bind `
#657 make keyboard shortcuts configurable
#783 Rich Support for Tweaking Modifier Keys
#833 Most common readline keybinding don't work (ctrl-a, ctrl-e, ctrl-w etc.)
#872 Flexible keymap (hotkeys / shortcut)
#1069 Ctrl+X not working in nano
#1100 CTRL+a does not work in tmux under Linux
#1120 1.0.0 release broke some keybindings
#1178 Change realod accelerator
#1185 Shortcuts break when using Alt key as Meta
#1199 Ctrl + W closes the terminal
#1200 [windows] Control characters not working!
#1279 Git automerge - nano edit fail
#1361 Hyperterm doesn't handle Alt key combinations correctly
#1424 Running nano from Hyper on Windows, doesn't allow me to exit with CTRL+X.
#1584 Plugins Existences
#1589 Crashes on open with invalid config
#1627 close on CTRL-W
#1776 Gaze is adding all folders in HOME to watch list
#1782 JOE Editor and Hyper, disabling shortcuts for proper use

ppot · 2017-02-15T00:37:13Z

@rauchg @matheuss @albinekb Here is a simpler keycap if you can review it.

ppot · 2017-02-15T01:06:24Z

@iamstarkov if you prefer to look at a simpler keymap for now

rauchg · 2017-02-16T18:43:33Z

.gitignore

@@ -6,6 +6,7 @@ node_modules

 # logs
 npm-debug.log
+.DS_Store


This doesn't belong in .gitignore as it's not a build artifact

rauchg · 2017-02-16T18:43:42Z

app/index.js

@@ -47,9 +47,12 @@ const fileUriToPath = require('file-uri-to-path');
 const isDev = require('electron-is-dev');

 // Ours
+const Keymap = resolve(__dirname, '../keymaps/darwin.json');
+console.log(Keymap);


Remove this please

rauchg · 2017-02-16T18:44:25Z

The only thing that's not clear to me is:

How do users change the keymap config?
How do plugin authors change the keymap config?

ppot · 2017-02-17T00:31:36Z

The current implementation lay ground for implementing an edit commands depending on the keybinding.

Allowing the keymap to be change is a different issue and this one.

iamstarkov

looks good to me

iamstarkov · 2017-02-17T14:08:16Z

app/menus/menus/window.js

+        accelerator: commands['window:minimize']
+      },
+      {
+        role: 'zoom'


this is confusing. Shall we have descriptive Label here and relevant hotkey?

I should make a key for the zoom that can override the default yes

teoulas · 2017-02-24T18:12:37Z

app/keymaps/linux.json

+  "pane:close":"Ctrl+Shift+W",
+
+  "editor:undo":"Ctrl+Shift+Z",
+  "editor:redo":"Ctrl+Shift+Z",


I guess this should change to a different key. Ctrl+Y is regularly used as redo, so Ctrl+Shift+Y? Same for the Windows keymap.

rauchg · 2017-03-02T04:05:31Z

Meaning?

On Wed, Mar 1, 2017 at 8:04 PM Benjamin Staneck ***@***.***> wrote: This PR looks like a massacre 🗡 — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1509 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAy8Xyt3DFaj2myQN1EhiHtrU-1_PqLks5rhj_SgaJpZM4MBKRT> .

-- – @rauchg <https://twitter.com/rauchg>

chabou · 2017-03-07T21:21:17Z

@ppot "Allowing the keymap to be change is a different issue and this one.". You mean Plugins can't use it yet ?

ppot · 2017-03-08T01:18:56Z

@chabou Yes, I didn't made plugins be able to update the keymap. Since I have no use case of plugins needing some keybinding. If you have a plugin in head needing this. I can test and update it.

iamstarkov · 2017-03-08T08:24:43Z

@ppot the cases for plugins to maintain hotkeys is hotkeys packs. For people migrating from iTerm2 there will be a package hyper-iterm2-hotkeys and similar

chabou · 2017-03-08T20:25:10Z

My plugin hyper-pane need some keybindings :
It would be awesome to register some hotkeys without using mousetrap and reattach keys each times that focus has changed : https://github.com/chabou/hyper-pane/blob/master/index.js#L420-L455

I have chosen the same way than @iamstarkov to attach my keys.
Another way is to tweak hterm internal keyboard like this but I REALLY prefer our way.

iamstarkov · 2017-03-08T20:33:06Z

yep, hyper-pane case is legit

chabou · 2017-03-08T20:58:45Z

It would be great to register to up, down and/or press event. In my plugin case, I would like to show shortcut indicator (with pane number), only when modifiers (ie. ctr+alt by default), and only them, are down.

RegisterKeys exported function should be evaluated after every config change.

I have a good idea of what plugins need. But maybe it should take place in another PR, after this one have been merged.

iamstarkov · 2017-03-10T09:17:15Z

@ppot another thing about allowing plugins to influence keymap is that, right now plugins doesnt override hyper's hotkeys. lets say, its enough for me to switch tabs with ctrl+tab and i dont care about cmd+alt+arrows for this. But i do want to navigate through panes with cmd+alt+arrows. so i can try (without luck, obviously) to remap hyper-panes hotkeys to this:

  paneNavigation: {
    navigation: {
      up:    'command+option+up',
      down:  'command+option+down',
      left:  'command+option+left',
      right: 'command+option+right'
    },
  },

but as far as hyper's electron menu's shorcuts has prio over mousetrap hotkeys, it doesnt work out.

I believe its valid use case.

iamstarkov · 2017-03-10T15:59:36Z

demo of aforementioned case chabou/hyper-pane#6

Keymaps used to be case sensitive, leading to a small handful of bugs (minimization in windows), and making custom key mapping more difficult.

coccyx · 2017-05-24T02:39:17Z

Wondering if this project is actively maintained? It seems impossible there are this many open issues referencing the same problem, with a user submitted PR, which goes weeks without any activity. I've kind of given up on waiting and decided I'll just live with the stock Windows terminal. What is the point in putting out binaries for all the other platforms other than MacOS if you can't even reverse-i-search in Bash?

danielbertolozi · 2017-05-24T18:51:39Z

Reinforcing what @coccyx just mentioned.
I use Vim both at home/university (Mac) and at work (Linux). At this point, it is impossible to use Hyper on my Linux, as lots of keybindings that use the Ctrl modifier are captured by Hyper - I can't cycle windows without it closing everything. Going back to Gnome Terminal for now.

mqsoh · 2017-05-24T19:00:54Z

Dereinforcing what others have mentioned, I'd like to thank @ppot and anyone else that worked on this ticket! I eagerly await a release with these changes and don't mind using my dumb old terminal for now.

timothyis · 2017-05-24T19:22:02Z

I just want to take a minute to say that Hyper is always being talked about by the core team in the zeit.chat slack channel. It's a tough one because we all have full-time jobs and ZEIT are super focused and busy working on the things that maintain their growth for now. They (ZEIT) actively try and find time to work on Hyper. Keymaps is a big PR and is hard to review properly, so I just want everyone to know that it is being talked about every day. ❤️

albinekb · 2017-05-26T16:47:03Z

This is now moving, part 1 is in master: #1867, part 2 coming: #1876 & more 💯

Locked due to github can't handle all this data in one view, page takes 20s to load from their servers....

ppot · 2017-06-03T00:09:24Z

Good news. Part 2 is in master with #1876!

timothyis · 2017-06-14T19:15:50Z

website/index.html

+
+    <h2 id="keymaps"><a href="#keymaps">Keymaps</a></h2>
+
+    <P> All commands keys can be changed. In order to change them, edit 


All command keys can be changed*

timothyis · 2017-06-14T19:16:28Z

website/index.html

+    <h2 id="keymaps"><a href="#keymaps">Keymaps</a></h2>
+
+    <P> All commands keys can be changed. In order to change them, edit 
+      <code>~/.hyper/config.js</code> and add to <code>keymaps</code> your desired change.</p>


add your desired change to <code>keymaps</code>*

timothyis · 2017-06-14T19:16:44Z

website/index.html

+      <code>~/.hyper/config.js</code> and add to <code>keymaps</code> your desired change.</p>
+      <p> Then Hyper will change the default with your custom change.</p>
+
+    <p> Exemple: <code>'window:devtools': 'Cmd+Alt+O'</code> <p>


ppot · 2017-12-17T01:25:26Z

As it was integrated. Closing the PR.

ppot force-pushed the keymaps branch from 36d7a92 to bc23cd3 Compare February 15, 2017 00:36

ppot assigned rauchg and matheuss Feb 15, 2017

ppot force-pushed the keymaps branch from f8f13b5 to 9ccf254 Compare February 16, 2017 03:02

rauchg reviewed Feb 16, 2017

View reviewed changes

ppot force-pushed the keymaps branch from 9ccf254 to e2556ed Compare February 17, 2017 00:20

iamstarkov approved these changes Feb 17, 2017

View reviewed changes

ppot mentioned this pull request Feb 24, 2017

Keyboard shortcut prefix fix for Windows, Linux (Ctrl+Shift). Fixes #1069. #1191

Closed

teoulas reviewed Feb 24, 2017

View reviewed changes

ppot mentioned this pull request Feb 26, 2017

Plugins Existances #1584

Closed

2 tasks

ppot force-pushed the keymaps branch from 794312d to 31eb2e1 Compare March 1, 2017 02:56

ppot force-pushed the keymaps branch from 6de1a85 to 146111a Compare March 4, 2017 22:18

hharnisc mentioned this pull request Mar 9, 2017

Improve Linux keyboard shortcuts #1616

Closed

iamstarkov mentioned this pull request Mar 10, 2017

overwrite default hyper shortcuts chabou/hyper-pane#6

Closed

ppot mentioned this pull request Mar 11, 2017

Hyper should fallback to default config when not specified in ~/.hyper.js #1588

Closed

ppot force-pushed the keymaps branch from 146111a to d976922 Compare March 11, 2017 00:32

MartyGentillon and others added 12 commits May 17, 2017 19:07

Fixed issue with keymap case sensitivity

b53426b

Keymaps used to be case sensitive, leading to a small handful of bugs (minimization in windows), and making custom key mapping more difficult.

simplification

bfa92d8

Set 1 -> load with default config if errors

231451b

Step 2 -> Provide notifications error

bdea424

Add keybind for windows:zoom

2ba0431

Remove file

33e2333

Word change

5f74ab4

Add DEV paths for dev testing

e680f4f

const and file rename

182d347

update website

ddab1d5

rebase

7cb6f34

rename hconf.js to config.js on website

41b5699

ppot force-pushed the keymaps branch from c88f7e1 to 41b5699 Compare May 17, 2017 23:09

MartyGentillon approved these changes May 20, 2017

View reviewed changes

ppot mentioned this pull request May 23, 2017

undefined in plugins array causes Hyper to refuse to open windows, with no visible errors whatsoever #1862

Closed

2 tasks

ppot mentioned this pull request May 25, 2017

Refactor menu internals #1867

Merged

ppot mentioned this pull request May 29, 2017

Emacs crashes when killing text (Ctrl + W) #1881

Closed

ppot mentioned this pull request Jun 10, 2017

Ctrl-based shortcuts don't work on Linux #274

Closed

vercel locked and limited conversation to collaborators Jun 14, 2017

timothyis suggested changes Jun 14, 2017

View reviewed changes

timothyis approved these changes Jun 14, 2017

View reviewed changes

ppot closed this Dec 17, 2017

ppot deleted the keymaps branch December 17, 2017 01:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keymaps #1509

Keymaps #1509

ppot commented Feb 15, 2017 •

edited

Loading

ppot commented Feb 15, 2017

ppot commented Feb 15, 2017

rauchg Feb 16, 2017

rauchg Feb 16, 2017

rauchg commented Feb 16, 2017

ppot commented Feb 17, 2017

iamstarkov left a comment

iamstarkov Feb 17, 2017

ppot Feb 17, 2017

teoulas Feb 24, 2017

ppot Feb 24, 2017

rauchg commented Mar 2, 2017 via email

chabou commented Mar 7, 2017

ppot commented Mar 8, 2017

iamstarkov commented Mar 8, 2017

chabou commented Mar 8, 2017

iamstarkov commented Mar 8, 2017

chabou commented Mar 8, 2017

iamstarkov commented Mar 10, 2017

iamstarkov commented Mar 10, 2017 •

edited

Loading

coccyx commented May 24, 2017

danielbertolozi commented May 24, 2017

mqsoh commented May 24, 2017

timothyis commented May 24, 2017

albinekb commented May 26, 2017 •

edited

Loading

ppot commented Jun 3, 2017

timothyis Jun 14, 2017

timothyis Jun 14, 2017

timothyis Jun 14, 2017

ppot commented Dec 17, 2017


		<h2 id="keymaps"><a href="#keymaps">Keymaps</a></h2>

		<P> All commands keys can be changed. In order to change them, edit

Keymaps #1509

Keymaps #1509

Conversation

ppot commented Feb 15, 2017 • edited Loading

Keymaps Feature

New file structure

New DEV structure

Resolve

ppot commented Feb 15, 2017

ppot commented Feb 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rauchg commented Feb 16, 2017

ppot commented Feb 17, 2017

iamstarkov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rauchg commented Mar 2, 2017 via email

chabou commented Mar 7, 2017

ppot commented Mar 8, 2017

iamstarkov commented Mar 8, 2017

chabou commented Mar 8, 2017

iamstarkov commented Mar 8, 2017

chabou commented Mar 8, 2017

iamstarkov commented Mar 10, 2017

iamstarkov commented Mar 10, 2017 • edited Loading

coccyx commented May 24, 2017

danielbertolozi commented May 24, 2017

mqsoh commented May 24, 2017

timothyis commented May 24, 2017

albinekb commented May 26, 2017 • edited Loading

ppot commented Jun 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ppot commented Dec 17, 2017

ppot commented Feb 15, 2017 •

edited

Loading

iamstarkov commented Mar 10, 2017 •

edited

Loading

albinekb commented May 26, 2017 •

edited

Loading