Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction pruning #249

Closed
1 of 2 tasks
voxain opened this issue Jul 2, 2021 · 1 comment · Fixed by #260
Closed
1 of 2 tasks

Reaction pruning #249

voxain opened this issue Jul 2, 2021 · 1 comment · Fixed by #260
Assignees
Labels
enhancement New feature or request

Comments

@voxain
Copy link
Contributor

voxain commented Jul 2, 2021

Type of Feature Request

  • New feature
  • Enhancement

Description

Sometimes it is really hard to delete an exact amount of messages without deleting too many of them while pruning, since it's often a large amount of messages and it's hard to guess how many there actually are.

I thought, what if you could configure an emoji, when being used as a reaction to a message, it first of course prompts the user, and then starts pruning everything up to that message?
Now, I have no idea how that can be done effectively and with a smart UX, but I think it's a nice idea so I wanted to suggest it.

Images and Sketches

@voxain voxain added the enhancement New feature or request label Jul 2, 2021
@zekroTJA
Copy link
Owner

zekroTJA commented Jul 25, 2021

What do you think about this implementation?

There are two modes:

  1. Delete single selected messages with the ❌ emote.
Screen.Recording.2021-07-25.at.10.34.36.mov
  1. Delete all messages sent after (and including) the message selected with the 🔻 emote.
Screen.Recording.2021-07-25.at.10.35.37.mov

This is the error message shown when clear selected is executed without any selection.
image

Because of API limitations, only the latest 100 messages are scanned for reactions. Also, only reactions set by the executing user are respected.

Edit:
And yes, I actually just noticed that the result message is buggy. xD

zekroTJA added a commit that referenced this issue Jul 25, 2021
@zekroTJA zekroTJA changed the title [FEATURE] Reaction pruning Reaction pruning Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants