Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve isPlacementActive common function #195

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Improve isPlacementActive common function #195

merged 1 commit into from
Oct 4, 2019

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Simply isPlacementActive by getting rid of duplicate code from getActiveTree

@mharis001 mharis001 added the enhancement Improves an existing feature label Oct 4, 2019
@mharis001 mharis001 added this to the 1.5.0 milestone Oct 4, 2019
@CreepPork CreepPork added cleanup Removes bloat from code and removed enhancement Improves an existing feature labels Oct 4, 2019
@mharis001 mharis001 merged commit 0a4942d into master Oct 4, 2019
@mharis001 mharis001 deleted the improve-isPlacementActive branch October 4, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilzar neilzar neilzar approved these changes

@CreepPork CreepPork CreepPork approved these changes

Assignees
No one assigned
Labels
cleanup Removes bloat from code
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mharis001 @CreepPork @neilzar