Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Switch Weapon context menu actions for vehicles #537

Merged
merged 66 commits into from
Mar 8, 2023
Merged

Add Switch Weapon context menu actions for vehicles #537

merged 66 commits into from
Mar 8, 2023

Conversation

ampersand38
Copy link
Member

When merged this pull request will:

  • Add vehicle switch weapon actions to make a vehicle's primary turret select a particular weapon/muzzle/magazine
    https://youtu.be/l1e4R2cQZFM

@mharis001 mharis001 added the feature Adds a new feature label Feb 1, 2021
@mharis001 mharis001 added this to the 1.11.0 milestone Feb 1, 2021
CreepPork
CreepPork reviewed Feb 24, 2021
View reviewed changes
addons/common/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/context_actions/functions/fnc_getVehicleWeaponActions.sqf Outdated Show resolved Hide resolved
addons/context_actions/functions/fnc_switchWeaponModifier.sqf Outdated Show resolved Hide resolved
addons/common/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/context_actions/CfgContext.hpp Outdated Show resolved Hide resolved
addons/context_actions/functions/fnc_getVehicleWeaponActions.sqf Outdated Show resolved Hide resolved
ampersand38 and others added 21 commits February 26, 2021 10:32
@ampersand38
Add weapon selection actions under Loadout
99d70dd
@ampersand38
Add Vehicle Logistics > Switch Weapons context actions
df56795
@ampersand38
Disable on player, fix macros
203792c
@ampersand38
Keybinds
bd38a6f
@ampersand38
getPosFromScreen already exists
9344e03 
zen-mod#496 (comment)
@ampersand38
Add Watch Curator Camera and Force Fire
dca7fd6 
Watch Curator Camera
Makes selected units watch the current curator camera location. This keybind is useful when making units look at upper floors, or when you are near players inside buildings where geometry may make `getPosFromScreen` intersections a little tricky.

Force Fire
Hold to force all selected to fire their current weapon.
https://www.youtube.com/watch?v=ml0xGoXfGY4
@ampersand38 @neilzar
Update addons/editor/stringtable.xml
ef47dfc 
Co-authored-by: Neil Evers <neil.evers.1995@gmail.com>
@ampersand38
Fire individual gunners and driver horn
3d1c6b5
@ampersand38
tabs to spaces
88ea381
@ampersand38
actually tabs to spaces
bb86b91
@ampersand38
Fixed super rapid fire
60367d0
@ampersand38
Load correct magazine
381dfbe
@ampersand38
Use targetEvent for action
ab0d510
@ampersand38
Menu layer and weapon name/picture
99bdc66 
https://youtu.be/5hq_pCK9_UM
@ampersand38
Updated description
0ba22b3
@ampersand38
Dynamic child actions for switchable weapons
2c1b74b
@ampersand38
Comments
919ffde
@ampersand38
params
6247b88
@ampersand38
remove diag
2e521b6
@ampersand38
fix args and example
b4d6e6b
@ampersand38 @CreepPork
Update addons/common/XEH_postInit.sqf
efc07ab 
Co-authored-by: Ralfs Garkaklis <ralfs@garkaklis.com>
ampersand38 and others added 3 commits February 26, 2021 10:51
@ampersand38 @neilzar
Update addons/context_actions/functions/fnc_selectVehicleWeaponDialog…
ef647d7 
….sqf

Co-authored-by: Neil Evers <neil.evers.1995@gmail.com>
@ampersand38 @neilzar
Update addons/context_actions/functions/fnc_getVehicleWeaponActions.sqf
333dac4 
Co-authored-by: Neil Evers <neil.evers.1995@gmail.com>
@ampersand38 @neilzar
Update addons/context_actions/functions/fnc_getVehicleWeaponActions.sqf
154f840 
Co-authored-by: Neil Evers <neil.evers.1995@gmail.com>
@mharis001 mharis001 changed the title Add Vehicle Logistics > Switch Weapon context action Add Switch Weapon context menu actions for vehicles Mar 7, 2023
@mharis001 mharis001 modified the milestones: Backlog, 1.13.0 Mar 7, 2023
@mharis001
Copy link
Member

I have extended the functionality to include all turrets of a vehicle (not just the primary one) and not require a unit to be present. Also, now uses loadMagazineInstantly, which prevents the long magazine load times for certain weapons. Pylon magazines are a bit weird and for some reason are not switched to in certain (unknown) situations. I think this is good to go for now and we can revisit that and look at improving the icons later.

@ampersand38
Copy link
Member Author

I have extended the functionality to include all turrets of a vehicle (not just the primary one) and not require a unit to be present. Also, now uses loadMagazineInstantly, which prevents the long magazine load times for certain weapons. Pylon magazines are a bit weird and for some reason are not switched to in certain (unknown) situations. I think this is good to go for now and we can revisit that and look at improving the icons later.

Minor issue of muzzle flash showing on switch weapon. https://youtu.be/5RQSWuFWnUY
If you feel that's ok then I'm good with it! Love the multi-turret stuff!

@mharis001
Copy link
Member

I think it is a fine trade-off for loading the magazine instantly and not requiring a gunner to be present.

@ampersand38 ampersand38 merged commit bd5c438 into zen-mod:master Mar 8, 2023
@ampersand38 ampersand38 deleted the vehicle-select-weapon branch March 8, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork left review comments

@rautamiekka rautamiekka rautamiekka left review comments

@mharis001 mharis001 mharis001 approved these changes

@neilzar neilzar neilzar approved these changes

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ampersand38 @mharis001 @rautamiekka @CreepPork @neilzar