Add multi-line edit box control types #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedmen
reviewed
Jul 4, 2019
| @@ -19,11 +19,20 @@ | |||
| #include "script_component.hpp" | |||
There was a problem hiding this comment.
You should consider putting the include before the documentation like in CBA/ACE. Otherwise it causes your line numbers to be messed up in case of errors.
There was a problem hiding this comment.
Yeah, need to make that change project wide.
There was a problem hiding this comment.
To not add all the changes in this PR, I guess you could merge this one and then make a new PR to change it.
There was a problem hiding this comment.
yeah, but could atleast make sure that future PR's are already doing that.
CreepPork
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
EDIT:MULTIandEDIT:CODEmulti-line edit box sub-types to dialog