Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes - Add support for dynamic value info #578

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Attributes - Add support for dynamic value info #578

merged 2 commits into from
Mar 30, 2021

Conversation

ffredyk
Copy link
Contributor

@ffredyk ffredyk commented Mar 24, 2021 •
edited by mharis001
Loading

When merged this pull request will:

  • Add _valueInfo evaluation only if the variable is a codeblock (typeName = "CODE")
  • Evaluate _valueInfo to be able to create combo attributes with dynamic values
  • Fallback to previous behaviour if _valueInfo is not a codeblock
  • Close addAttribute Value Info evaluation #576

@ffredyk ffredyk changed the title add: _valueInfo evaluation Attribute _valueInfo evaluation Mar 24, 2021
@neilzar neilzar added the enhancement Improves an existing feature label Mar 24, 2021
@neilzar neilzar added this to the 1.11.0 milestone Mar 24, 2021
@mharis001 mharis001 changed the title Attribute _valueInfo evaluation Attributes - Allow for dynamic combo box entries Mar 25, 2021
@mharis001 mharis001 changed the title Attributes - Allow for dynamic combo box entries Attributes - Add support for dynamic value info Mar 30, 2021
@mharis001 mharis001 merged commit 7b27ef2 into zen-mod:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

@neilzar neilzar neilzar approved these changes

Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

addAttribute Value Info evaluation
3 participants
@ffredyk @neilzar @mharis001