Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Area Markers - Only allow editing when in markers mode #765

Merged
merged 6 commits into from
Jul 14, 2024
Merged

Area Markers - Only allow editing when in markers mode #765

merged 6 commits into from
Jul 14, 2024

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Only allow editing area markers when in markers mode (matches behaviour of engine-based icon markers)
  • Switch back to PFH for updating icon visibility
    • Event based method for detecting map visibility does not always work (e.g., when a dialog is opened)

@mharis001 mharis001 added the enhancement Improves an existing feature label Jun 7, 2024
@mharis001 mharis001 added this to the 1.15.0 milestone Jun 7, 2024
@mharis001 mharis001 requested a review from Kexanone July 12, 2024 01:23
@mharis001 mharis001 merged commit 2b1a22b into master Jul 14, 2024
3 checks passed
@mharis001 mharis001 deleted the area-markers-editing branch July 14, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautamiekka rautamiekka rautamiekka requested changes

@Kexanone Kexanone Kexanone approved these changes

Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Only allow manipulating area markers when in marker tab
3 participants
@mharis001 @rautamiekka @Kexanone