Adding support for SegmentTimeline and SegmentList #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding structs based off the DASH XSDs to support SegmentTimeline and SegmentList. Reworked existing structs to allow adding timelines and lists at different points in the manifest.
Renamed Intptr to Int64ptr since that is what it is and made a new Intptr func to deal with a normal int. Added a few others needed by the newer structs’ properties and updated touch points as needed.
| Timescale *uint32 `xml:"timescale,attr,omitempty"` | ||
| PresentationTimeOffset *uint64 `xml:"presentationTimeOffset,attr,omitempty"` | ||
| IndexRange *string `xml:"indexRange,attr,omitempty"` | ||
| indexRangeExact *bool `xml:"indexRangeExact,attr,omitempty"` |
There was a problem hiding this comment.
This is private and doesn't seem to be used anywhere, any reason?
| @@ -174,7 +171,7 @@ func (m *MPD) AddNewAdaptationSetAudio(mimeType string, segmentAlignment bool, s | |||
| as := &AdaptationSet{ | |||
| MimeType: Strptr(mimeType), | |||
| SegmentAlignment: Boolptr(segmentAlignment), | |||
| StartWithSAP: Intptr(startWithSAP), | |||
| StartWithSAP: Int64ptr(startWithSAP), | |||
There was a problem hiding this comment.
Side note unrelated to your change: This certainly doesn't need to be an Int64
|
LGTM. |
# Conflicts: # mpd/mpd.go Updated tests to have correct element order in AdaptationSet.
philcluff
added a commit
that referenced
this pull request
Mar 10, 2016
Adding support for SegmentTimeline and SegmentList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work related to #26
Added in additional structs to model SegmentTimeline and SegmentList and updated Period, AdaptationSet and Representation to include them as options.