Add Error test cases and simplify duration parsing logic #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuarthicks
requested changes
Oct 31, 2017
mpd/duration.go
Outdated
| if str[offset] != 'P' { | ||
| return 0, errors.New("input duration does not have a valid prefix") | ||
| // Check that only the parts we expect exist and that everything's in the correct order | ||
| r := regexp.MustCompile( |
There was a problem hiding this comment.
Can we move the regex initialisation outside the method? Compiling the regex on every invocation feels unnecessary.
mpd/duration.go
Outdated
| // Check that only the parts we expect exist and that everything's in the correct order | ||
| r := regexp.MustCompile( | ||
| "^P" + // Must start with a 'P' | ||
| "(\\d+D)?" + // We only allow Days for durations, not Months or Years |
There was a problem hiding this comment.
Can we use named captures? I prefer not to read captures out by slice index.
There was a problem hiding this comment.
Go doesn't really support named captures without doing a double loop of an array of parameter names and one of parameters
stuarthicks
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.