Fix UUID splitting #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
commented
Mar 2, 2018
|
|
||
| func (d Duration) MarshalXMLAttr(name xml.Name) (xml.Attr, error) { | ||
| return xml.Attr{name, d.String()}, nil | ||
| return xml.Attr{Name: name, Value: d.String()}, nil |
There was a problem hiding this comment.
unrelated linting fix
stuarthicks
reviewed
Mar 2, 2018
mpd/mpd_test.go
Outdated
| s, _ := m.AddNewAdaptationSetVideo("7357", DASH_MIME_TYPE_VIDEO_MP4, VALID_SCAN_TYPE, VALID_SEGMENT_ALIGNMENT, VALID_START_WITH_SAP) | ||
|
|
||
| cp, err := s.AddNewContentProtectionRoot("") | ||
| cp, err := s.AddNewContentProtectionRoot2("") |
There was a problem hiding this comment.
Can we come up with a more descriptive name please?
There was a problem hiding this comment.
AddNewContentProtectionRootThatDoesntMisformatUUIDs ?
There was a problem hiding this comment.
AddNewContentProtectionRootFixedUUID?
|
Think one test for the old AddNewContentProtectionRoot needs to be left in. |
thomshutt
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.