Make a separate method for creating Adaptation Sets with IDs #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuarthicks
reviewed
Mar 9, 2018
| examples-ondemand: | ||
| go run examples/ondemand.go | ||
|
|
||
| generate: |
stuarthicks
reviewed
Mar 9, 2018
helpers/testfixtures/testfixtures.go
Outdated
| "io/ioutil" | ||
| "testing" | ||
| "github.com/stretchr/testify/require" | ||
| "os" |
There was a problem hiding this comment.
imports ordering/grouping please
stuarthicks
approved these changes
Mar 9, 2018
sarge
added a commit
to indiereign/go-dash
that referenced
this pull request
Jun 16, 2018
* master: Make a separate method for creating Adaptation Sets with IDs (zencoder#46) Fix UUID splitting # Conflicts: # mpd/mpd.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also reverts some re-ordering of attributes.