Skip to content

Bumped to tagged AWS version and updated to use new changed method signature #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2016
Merged

Bumped to tagged AWS version and updated to use new changed method signature #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions glide.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion glide.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package: github.com/zencoder/go-remote-config
import:
- package: github.com/aws/aws-sdk-go
version: f28e73d4791500a90d49190e0a01b769748cc2a8
version: v1.0.9
subpackages:
- aws
- internal/endpoints
Expand Down
4 changes: 3 additions & 1 deletion s3_signing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/s3"
"github.com/aws/aws-sdk-go/aws/session"
)

var (
Expand Down Expand Up @@ -40,11 +41,12 @@ func generateSignedS3URL(region AWSRegion, bucket string, key string, expiry uin
}

// We want to use the default credentials chain so that it will attempt Env & Instance role creds
svc := s3.New(&aws.Config{
sess := session.New(&aws.Config{
Region: aws.String(string(region)),
Endpoint: aws.String(endpoint),
S3ForcePathStyle: aws.Bool(s3ForcePathStyle),
})
svc := s3.New(sess)

req, _ := svc.GetObjectRequest(&s3.GetObjectInput{
Bucket: &bucket,
Expand Down