Skip to content

Fix request content type and response parsing #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2015

Conversation

skidder
Copy link
Contributor

@skidder skidder commented Apr 16, 2015

No description provided.

Scott Kidder added 3 commits April 8, 2015 11:27
Specify the utf-8 character-encoding in the content-type HTTP request
header.
@@ -21,6 +21,7 @@
FAILED("failed"),
CANCELLED("cancelled"),
NO_INPUT("no_input"),
UPLOADING("uploading"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the int to long changes but not sure what the context of this is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #10 prompted this change; customer reported encountering an exception while parsing responses for outputs that were in an 'uploading' state.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got it. lgtm

@bctvigil
Copy link

other than comment lgtm

skidder pushed a commit that referenced this pull request Apr 16, 2015
…ponse-parsing

Fix request content type and response parsing
@skidder skidder merged commit 0a5f886 into master Apr 16, 2015
@skidder skidder deleted the fix-request-content-type-and-response-parsing branch April 16, 2015 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants