Fix cache refresh messages

cache/aws_ec2.go

@@ -61,26 +61,26 @@ func (g *AwsEc2Cache) Len() int {
 }
 
 // Refresh refreshes resources
-func (g *AwsEc2Cache) Refresh(force bool) (err error) {
+func (g *AwsEc2Cache) Refresh(force bool) (refreshed bool, err error) {
 	if g.cacheOutdated() == false && force == false {
 		g.Read()
-		return nil
+		return false, nil
 	}
 
 	g.Provider.Init()
 
 	result, err := g.Provider.GetResources()
 	if err != nil {
-		return err
+		return false, err
 	}
 	for _, r := range result {
 		g.Result = append(g.Result, r.(*resources.Ec2Instance))
 	}
 	err = g.Save()
 	if err != nil {
-		return err
+		return false, err
 	}
-	return nil
+	return true, nil
 }
 
 // Save saves the cache to cache file

cache/cache.go

@@ -6,7 +6,7 @@ import "github.com/zendesk/goship/resources"
 type GoshipCache interface {
 	CacheName() string
 	Resources() []resources.Resource
-	Refresh(bool) error
+	Refresh(bool) (bool, error)
 	Save() error
 	Read() error
 	Len() int

cache/cache_list.go

@@ -20,10 +20,17 @@ func (cl *GlobalCacheList) RefreshInParallel(force bool) error {
 		go func(cache GoshipCache) {
 			refreshStart := time.Now()
 			defer wg.Done()
-			cache.Refresh(force)
+			refreshed, err := cache.Refresh(force)
+			if err != nil {
+				color.PrintRed(fmt.Sprintf("Error while refreshing cache: %s\n", err))
+			}
 			refreshElapsed := time.Since(refreshStart)
 			if config.GlobalConfig.Verbose {
-				color.PrintGreen(fmt.Sprintf("[%s] Cache refresh in: %s. Read %d instances\n", cache.CacheName(), refreshElapsed, cache.Len()))
+				if refreshed {
+					color.PrintGreen(fmt.Sprintf("[%s] Cache refresh took: %s. Read %d instances\n", cache.CacheName(), refreshElapsed, cache.Len()))
+				} else {
+					color.PrintGreen(fmt.Sprintf("[%s] Cache read took: %s. Read %d instances\n", cache.CacheName(), refreshElapsed, cache.Len()))
+				}
 			}
 		}(c)
 	}