Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Runner adds exceptions to instrumentation payload #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bestie
Copy link
Contributor

@bestie bestie commented Jun 22, 2023

The DataDog integration checks for :exception in the instrumentation payload but Runner does not add it.

Looks like an oversight to me. Should it be added?

@bestie
Copy link
Contributor Author

bestie commented Jun 22, 2023

Example of an exception check

if event.payload.key?(:exception)

Copy link
Contributor

@deepredsky deepredsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to set the exception manually, we are using active supports notification mechanism that does this automatically for exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants