Track message delivery delays #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasch
force-pushed
the
dasch/instrument-message-delay
branch
from
03bfc1f
to
5ec1eab
Compare
Write down the time a message was produced and include timing information in the message ack notifications.
dasch
force-pushed
the
dasch/instrument-message-delay
branch
from
5ec1eab
to
d0084b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write down the time a message was produced and include timing information in the message ack notifications. This will also fit well with KIP-32 once we switch to Kafka 0.10 APIs in the future.
My main concern is the switch to instrumenting individual message acks – when buffering e.g. 1,000 messages and delivering them at once, the cost of instrumentation could stack up...