fix assets precompile that broke during rails 6.1 upgrade #3949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
worth adding a CI test to ensure precompile works and includes expected plugin files? |
adammw
reviewed
Apr 19, 2021
| @@ -110,10 +110,6 @@ def add_decorators | |||
| end | |||
| end | |||
|
|
|||
| def add_assets_to_precompile | |||
There was a problem hiding this comment.
why is this no longer required? rails upgrade does it automatically?
There was a problem hiding this comment.
yeah, it's automatic, either because of the new version or because it was in the wrong position before
adammw
approved these changes
Apr 19, 2021
|
idk how to write that test, so not going to invest more effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3948
nobody noticed because old assets stayed around
/cc @zendesk/compute