safely deserialize k8 yaml #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Aug 4, 2023
| @@ -6,7 +6,14 @@ def self.parse_file(contents, filepath) | |||
|
|
|||
| if filename.ends_with?('.yml', '.yaml') | |||
| # NOTE: this will always return an array of entries | |||
| YAML.load_stream(contents, filepath) | |||
There was a problem hiding this comment.
wrapping this into a yaml_safe_load_stream method would be nice + a test that makes sure it actually does not load unsafe
I couldn't find any other usages where the stream content can come from an untrusted source |
grosser
reviewed
Aug 7, 2023
|
don't worry about bundle_audit that can be another PR |
Co-authored-by: Michael Grosser <michael@grosser.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Samson is a public repo, do not include Zendesk-internal information, urls, etc.
Using YAML.load_stream is unsafe and allows instantiating arbitrary classes which may lead to remote code execution (RCE)
I had to use multiple streams because Samson needs to support multiple documents in a single yaml file
References
Risks