This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
Use pip for backward compatibility #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluecloudes
changed the title
sfdye
reviewed
Jul 8, 2020
| @@ -4,7 +4,12 @@ set -v | |||
|
|
|||
| echo 'Installing bandit' | |||
| #pip install --user bandit | |||
| pip3 install bandit | |||
| if [ -x "$(command -v pip3)" ]; then | |||
There was a problem hiding this comment.
Actually I think pip install bandit is enough
It will be more convincing if you can test allura's bandit job with this branch
There was a problem hiding this comment.
Agree, but to keeping the changes of @everops-alex, to cover other cases who doesn't have pip3 it uses previous command
GervasioCalderon
approved these changes
Jul 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pip command for backward compatibility
Currently travis job failing for zopim-allura repo, due to change from pip to pip3, this change allows backward compatibility
CC
@zendesk/fangorn