This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Remove insecure md5 example #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tdutrion I cherry picked your commit fixing md5 usage in the docs. Thanks. |
weierophinney
suggested changes
May 6, 2019
weierophinney
approved these changes
May 6, 2019
Xerkus
added a commit
that referenced
this pull request
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Old documentation for
CredentialTreatmentAdapterprovidesmd5()in its usage example which might prompt users to utilize insecure practices. This PR removesmd5()usage from the documentation and adds further guidance towardsCallbackCheckAdapterand PHP functionspassword_hash()andpassword_verify()