This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Updated dependencies to allow stdlib v3 #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PHP: `^5.5 || ^7.0` - zend-stdlib `^2.7 || ^3.0`, as the features used are available in each - phpunit `^4.5`, to ensure availability of prophecy
Restricted the branch exception to a regext that matches tags specifically.
composer.json
Outdated
| "zendframework/zend-stdlib": "^2.7 || ^3.0", | ||
| "fabpot/php-cs-fixer": "1.7.*", | ||
| "phpunit/PHPUnit": "~4.0" | ||
| "phpunit/PHPUnit": "^4.5" |
There was a problem hiding this comment.
Need to check this one: it would be good to push at least to the current patch release here.
There was a problem hiding this comment.
This is for the 2.6 series; I think this is likely sufficient, but I can bump later if desired. (I see master uses 4.8.21 or something similar.)
There was a problem hiding this comment.
Ah, just seen that this is 4.x, not 5.x
To mimic current master (3.0.* series).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the 2.6 series to allow using zend-stdlib 2.7 or 3.0 releases. The only functionality used from zend-stdlib is the
ArrayObjectimplementation, which maintains compatibility across versions.