This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fix Composer Dependency: EventManager is required for TableGateway #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @weierophinney @Maks3w |
|
👍 There are a lot of discussion about this type of issue.. this PR is PERFECT! |
|
We already have a "suggest" entry for "zendframework/zend-eventmanager": "@~2.4; required when using the TableGateway subcomponent"and do similarly for the servicemanager. |
|
I'll close this for continue the discussion on #25. |
Closed
ezimuel
pushed a commit
that referenced
this pull request
Nov 30, 2017
…tasource-for-resultset use $returnType as ArrayObject for arrayobject prototype
weierophinney
pushed a commit
that referenced
this pull request
Mar 27, 2018
Feature/integration tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As stated, this currently causes issues with anyone that is using TableGateway as the EventManager is a dependency.
Workaround