Updated to php-coveralls/php-coveralls #282
Conversation
With version 2 package has been renamed from "satooshi/php-coveralls" to "php-coveralls/php-coveralls", and the script has been renamed from "coveralls" to "php-coveralls"
| @@ -54,7 +54,6 @@ | |||
| "@cs-check", | |||
| "@test" | |||
| ], | |||
| "upload-coverage": "coveralls -v", | |||
There was a problem hiding this comment.
Why this change, exactly? The point of having a script is so that we can make a change to the script, without having to make a change to the travis configuration...
This should change to:
"upload-coverage": "php-coveralls -v",and then the .travis.yml only needs a change in terms of the COVERAGE_DEPS declaration.
I'll take care of that during merge.
There was a problem hiding this comment.
@weierophinney I think this is what we agreed on slack and what was merged into maintainers repository:
zendframework/maintainers#38
The script is only used in travis build and imho it shouldn't be available to the developers.
There was a problem hiding this comment.
@webimpress I'd totally forgotten that conversation!
I've opened #288 to re-instate these changes.
Updated to php-coveralls/php-coveralls
|
Thanks, @webimpress. |
|
@Xerkus We do not need to add patches that only change docs or QA tooling to milestones or to the changelogs; these are internal and not user facing. |
With version 2 package has been renamed from
satooshi/php-coverallstophp-coveralls/php-coveralls, and the script has been renamed fromcoverallstophp-coveralls