This repository was archived by the owner on Jan 29, 2020. It is now read-only.
simple correction example of pipes in route #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhonmike
commented
Oct 24, 2016
| Zend\Expressive\Container\ApplicationFactory::ROUTING_MIDDLEWARE, | ||
| Zend\Expressive\Container\ApplicationFactory::DISPATCH_MIDDLEWARE, | ||
| [ /* ... */ ], | ||
| ], |
There was a problem hiding this comment.
There was a problem hiding this comment.
Indentation was correct in the original. The renderer we use, mkdocs, indents the code blocks so that they properly appear under the bullet point to which they reference.
weierophinney
suggested changes
Nov 11, 2016
| Zend\Expressive\Container\ApplicationFactory::ROUTING_MIDDLEWARE, | ||
| Zend\Expressive\Container\ApplicationFactory::DISPATCH_MIDDLEWARE, | ||
| [ /* ... */ ], | ||
| ], |
There was a problem hiding this comment.
Indentation was correct in the original. The renderer we use, mkdocs, indents the code blocks so that they properly appear under the bullet point to which they reference.
| $pipeline->pipe($container->get('AuthenticationMiddleware)'); | ||
| $pipeline->pipe($container->get('AuthorizationMiddleware)'); | ||
| $pipeline->pipe($container->get('AuthenticationMiddleware')); | ||
| $pipeline->pipe($container->get('AuthorizationMiddleware')); |
There was a problem hiding this comment.
These were fixed in a previous pull request.
|
corrected @weierophinney |
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
simple correction example of pipes in route
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
|
Thanks, @jhonmike! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.