Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Conversation

Rud5G
Copy link

@Rud5G Rud5G commented Feb 14, 2017

Resolves #446

Argument 2 passed to Zend\Expressive\Container\ApplicationFactory::injectRoutesAndPipeline() must be of the type array,
object given

IMHO: $config is not an array.

@zendframework

Resolves zendframework#446

Argument 2 passed to Zend\Expressive\Container\ApplicationFactory::injectRoutesAndPipeline() must be of the type array,
object given
@michalbundyra
Copy link
Member

@Rud5G It's wrong, $config is ArrayObject or array, please see #447 which resolves #446. Thanks

@michalbundyra
Copy link
Member

I mean your solution is also gonna work, but this is what we have before, and probably we don't want to pass whole $container but just configuration as we have for example for marshalLegacyFinalHandler method.

@Rud5G
Copy link
Author

Rud5G commented Feb 14, 2017

True, i just converted the function and call to injectRoutesAndPipeline back to its previous version.
i just found: weierophinney/zend-expressive@9faf31e381037217d36ce5467ceec304b4918aad

ps: i like your added tests.

@Rud5G
Copy link
Author

Rud5G commented Feb 14, 2017

Closing now.

@Rud5G Rud5G closed this Feb 14, 2017
@michalbundyra
Copy link
Member

@Rud5G Nice found! I've updated my PR - cherry-picked the @weierophinney commit and rebased. Added also typehint in method marshalLegacyFinalHandler as it is now always array. Thanks!

@Rud5G Rud5G deleted the issue-446-param-2-injectRoutesAndPipeline branch February 14, 2017 13:23
@Rud5G
Copy link
Author

Rud5G commented Feb 14, 2017

@webimpress Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants