This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Use PHP 7 deps in composer.lock
#451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to keep 7.X deps in the `composer.lock`.
Otherwise we have uninstallable constraints.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, because PHPUnit 6 only works against PHP 7, we need to keep PHPUnit 5.X versions in the
composer.lock. This is problematic when contributors do an update while running PHP 7 and then push the updatedcomposer.lock.What this patch does is:
.travis.ymlto update those libraries when running under PHP 5.6, forcing installation of the PHPUnit 5.7 variants. This then also installs locked dependencies.