Update MiddlewareFactory.php

[wesperinteractive]

Re-use the handler() method instead of directly instantiating a RequestHandlerMiddleware instance within the prepare() method.

[Ocramius]

Requires test additions and better PR/Commit description

[geerteltink]

Not sure if this needs additional tests. All it does is using the internal method to return a new instance of RequestHandlerMiddleware instead of returning RequestHandlerMiddleware directly.

[geerteltink]

Also the tests are already in place:

zend-expressive/test/MiddlewareFactoryTest.php

Lines 203 to 217 in a7bd1e9

	public function testPrepareDecoratesRequestHandlersAsMiddleware()
	{
	$handler = $this->prophesize(RequestHandlerInterface::class)->reveal();
	$middleware = $this->factory->prepare($handler);
	$this->assertInstanceOf(RequestHandlerMiddleware::class, $middleware);
	$this->assertAttributeSame($handler, 'handler', $middleware);
	}
	public function testHandlerDecoratesRequestHandlersAsMiddleware()
	{
	$handler = $this->prophesize(RequestHandlerInterface::class)->reveal();
	$middleware = $this->factory->handler($handler);
	$this->assertInstanceOf(RequestHandlerMiddleware::class, $middleware);
	$this->assertAttributeSame($handler, 'handler', $middleware);
	}

[Ocramius]

Gotcha: not having any context on the nature of the patch besides the diff, I asked for a test, assuming a functional change.

[weierophinney]

Thanks, @wesperinteractive