Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Conversation

shadyan
Copy link
Contributor

@shadyan shadyan commented Mar 21, 2018

See here:
https://docs.zendframework.com/zend-expressive/v3/features/container/factories/#zendviewrendererfactory

Says "no additional services are required", but then lists a dependency.

I made a separate pull request for this since this case might be a bit more complex. My understanding is that the actual dependency is the UrlHelper.
The ZendViewRendererFactory comments added some more confusion:

Requires the Zend\Expressive\Router\RouterInterface service (for creating the UrlHelper instance).

https://github.com/zendframework/zend-expressive-zendviewrenderer/blob/master/src/ZendViewRendererFactory.php

In any case, I think this small change should suffice to relieve most of the confusion.

  • Is this related to documentation?
    • Is it a typographical and/or grammatical fix?
    • Is it new documentation?

@weierophinney weierophinney merged commit 242463e into zendframework:master Apr 4, 2018
weierophinney added a commit that referenced this pull request Apr 4, 2018
…re-description-error

Correct ZendViewRendererFactory feature description
weierophinney added a commit that referenced this pull request Apr 4, 2018
weierophinney added a commit that referenced this pull request Apr 4, 2018
@weierophinney
Copy link
Member

Thanks, @shadyan! I reviewed the actual requirements, and made a few other changes on update to reflect how the factory works. Thanks for prodding me via this patch!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants