This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Correct ZendViewRendererFactory feature description #603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here:
https://docs.zendframework.com/zend-expressive/v3/features/container/factories/#zendviewrendererfactory
Says "no additional services are required", but then lists a dependency.
I made a separate pull request for this since this case might be a bit more complex. My understanding is that the actual dependency is the
UrlHelper
.The
ZendViewRendererFactory
comments added some more confusion:https://github.com/zendframework/zend-expressive-zendviewrenderer/blob/master/src/ZendViewRendererFactory.php
In any case, I think this small change should suffice to relieve most of the confusion.