Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
"zendframework/zend-stdlib": "~2.5"
},
"require-dev": {
"zendframework/zend-filter": "~2.5",
"zendframework/zend-filter": "~2.6",
"zendframework/zend-i18n": "~2.5",
"zendframework/zend-servicemanager": "~2.5",
"zendframework/zend-validator": "~2.5",
"zendframework/zend-progressbar": "~2.5",
"fabpot/php-cs-fixer": "1.7.*",
"phpunit/PHPUnit": "~4.0"
},
Expand Down
1 change: 1 addition & 0 deletions src/Transfer/Adapter/AbstractAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,7 @@ public function hasErrors()
public function addFilter($filter, $options = null, $files = null)
{
if (is_string($filter)) {
$options = (null !== $options && is_scalar($options)) ? [$options] : $options;
$filter = $this->getFilterManager()->get($filter, $options);
}

Expand Down
29 changes: 20 additions & 9 deletions src/Transfer/Adapter/FilterPluginManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
namespace Zend\File\Transfer\Adapter;

use Zend\Filter\FilterPluginManager as BaseManager;
use Zend\Filter\File;

/**
* Plugin manager implementation for the filter chain.
Expand All @@ -21,15 +22,25 @@
class FilterPluginManager extends BaseManager
{
/**
* Default set of filters
* Constructor
*
* @var array
* Merges default aliases pertinent to this plugin manager with those
* defined in the parent filter plugin manager.
*
* @param null|\Zend\ServiceManager\ConfigInterface|\Interop\Container\ContainerInterface $configOrContainerInstance
* @param array $v3config If $configOrContainerInstance is a container, this
* value will be passed to the parent constructor.
*/
protected $aliases = [
'decrypt' => 'filedecrypt',
'encrypt' => 'fileencrypt',
'lowercase' => 'filelowercase',
'rename' => 'filerename',
'uppercase' => 'fileuppercase',
];
public function __construct($configOrContainerInstance = null, array $v3config = [])
{
$this->aliases = array_merge([
'decrypt' => File\Decrypt::class,
'encrypt' => File\Encrypt::class,
'lowercase' => File\LowerCase::class,
'rename' => File\Rename::class,
'uppercase' => File\UpperCase::class,
], $this->aliases);

parent::__construct($configOrContainerInstance, $v3config);
}
}
52 changes: 24 additions & 28 deletions test/Transfer/Adapter/AbstractTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -412,34 +412,31 @@ public function testAdapterShouldAllowRetrievingDestinationsForAnArrayOfSpecifie

public function testSettingAndRetrievingOptions()
{
$this->assertEquals(
[
'bar' => ['ignoreNoFile' => false, 'useByteString' => true],
'baz' => ['ignoreNoFile' => false, 'useByteString' => true],
'foo' => ['ignoreNoFile' => false, 'useByteString' => true, 'detectInfos' => true],
'file_0_' => ['ignoreNoFile' => false, 'useByteString' => true],
'file_1_' => ['ignoreNoFile' => false, 'useByteString' => true],
], $this->adapter->getOptions());
$this->assertEquals([
'bar' => ['ignoreNoFile' => false, 'useByteString' => true],
'baz' => ['ignoreNoFile' => false, 'useByteString' => true],
'foo' => ['ignoreNoFile' => false, 'useByteString' => true, 'detectInfos' => true],
'file_0_' => ['ignoreNoFile' => false, 'useByteString' => true],
'file_1_' => ['ignoreNoFile' => false, 'useByteString' => true],
], $this->adapter->getOptions());

$this->adapter->setOptions(['ignoreNoFile' => true]);
$this->assertEquals(
[
'bar' => ['ignoreNoFile' => true, 'useByteString' => true],
'baz' => ['ignoreNoFile' => true, 'useByteString' => true],
'foo' => ['ignoreNoFile' => true, 'useByteString' => true, 'detectInfos' => true],
'file_0_' => ['ignoreNoFile' => true, 'useByteString' => true],
'file_1_' => ['ignoreNoFile' => true, 'useByteString' => true],
], $this->adapter->getOptions());
$this->assertEquals([
'bar' => ['ignoreNoFile' => true, 'useByteString' => true],
'baz' => ['ignoreNoFile' => true, 'useByteString' => true],
'foo' => ['ignoreNoFile' => true, 'useByteString' => true, 'detectInfos' => true],
'file_0_' => ['ignoreNoFile' => true, 'useByteString' => true],
'file_1_' => ['ignoreNoFile' => true, 'useByteString' => true],
], $this->adapter->getOptions());

$this->adapter->setOptions(['ignoreNoFile' => false], 'foo');
$this->assertEquals(
[
'bar' => ['ignoreNoFile' => true, 'useByteString' => true],
'baz' => ['ignoreNoFile' => true, 'useByteString' => true],
'foo' => ['ignoreNoFile' => false, 'useByteString' => true, 'detectInfos' => true],
'file_0_' => ['ignoreNoFile' => true, 'useByteString' => true],
'file_1_' => ['ignoreNoFile' => true, 'useByteString' => true],
], $this->adapter->getOptions());
$this->assertEquals([
'bar' => ['ignoreNoFile' => true, 'useByteString' => true],
'baz' => ['ignoreNoFile' => true, 'useByteString' => true],
'foo' => ['ignoreNoFile' => false, 'useByteString' => true, 'detectInfos' => true],
'file_0_' => ['ignoreNoFile' => true, 'useByteString' => true],
'file_1_' => ['ignoreNoFile' => true, 'useByteString' => true],
], $this->adapter->getOptions());
}

public function testGetAllAdditionalFileInfos()
Expand Down Expand Up @@ -601,10 +598,9 @@ public function testTransferDestinationAtNonExistingElement()
public function testSettingMagicFile()
{
$this->adapter->setOptions(['magicFile' => 'test/file']);
$this->assertEquals(
[
'bar' => ['magicFile' => 'test/file', 'ignoreNoFile' => false, 'useByteString' => true],
], $this->adapter->getOptions('bar'));
$this->assertEquals([
'bar' => ['magicFile' => 'test/file', 'ignoreNoFile' => false, 'useByteString' => true],
], $this->adapter->getOptions('bar'));
}

/**
Expand Down
13 changes: 11 additions & 2 deletions test/Transfer/Adapter/HttpTestMockAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,21 @@ public static function isApcAvailable()

public static function apcTest($id)
{
return ['total' => 100, 'current' => 100, 'rate' => 10];
return [
'total' => 100,
'current' => 100,
'rate' => 10,
];
}

public static function uPTest($id)
{
return ['bytes_total' => 100, 'bytes_uploaded' => 100, 'speed_average' => 10, 'cancel_upload' => true];
return [
'bytes_total' => 100,
'bytes_uploaded' => 100,
'speed_average' => 10,
'cancel_upload' => true,
];
}

public function switchApcToUP()
Expand Down