Updated dependencies - PHPUnit 5.7 and 6.0, dropped PHP5.5 support, QA Tools #115
Conversation
|
Thanks for your work, but:
All this in one commit?! Btw. This is more than a ugly job for a reviewer. |
|
@froschdesign Yeah... I know it's a lot for one commit. I can split it for just update PHPUnit and then license headers. The problem is also with docheader that we can't exclude some files. Maybe we should exclude the whole |
|
Ok, I'll split it later into smaller commits and push force. Sorry for huge commit ... |
I mean this: malukenho/docheader#13 |
Changed domain from zendframework.github.io to docs.zendframework.com
- changed `PHPUnit_Framework_TestCase` to `PHPUnit\Framework\TestCase` - changed `setExpectedException` to `expectException` and `expectExceptionMessage` - changed `getMock` to `createMock`
and updated license headers in files
Dependencies updated to the latest versions. Always prefered version is used first. Updated travis configuration to run tests with lowest/locked/latest dependencies and run all checks (license headers, cs, tests). Added proper check to install legacy dependencies on PHP5.6.
Changed to method call instead. Then we can check if the exception is thrown on a correct part of the test.
Optimized imports - alphabetical order and removed unused.
- aligned key value pairs - removed redundant empty lines - added missing trailing comma
|
@froschdesign PR updated. Please have a look and let me know what you think. Thanks! |
src/Client.php
Outdated
| "Cannot handle content type '{$this->encType}' automatically" | ||
| ); | ||
| throw new Client\Exception\RuntimeException(sprintf( | ||
| 'Cannot handle content type "%s" automatically', |
There was a problem hiding this comment.
Those swapped quotes broken tests. Is this change required by CS tool?
|
@Xerkus reverted. All green now. Thanks! |
| "zendframework/zend-uri": "^2.5", | ||
| "zendframework/zend-validator": "^2.5" | ||
| "php": "^5.6 || ^7.0", | ||
| "zendframework/zend-loader": "^2.5.1", |
There was a problem hiding this comment.
please revert dependencies bump, it is outside the scope of this PR
There was a problem hiding this comment.
Why you think it should be outside the scope of this PR? IMHO it should be in this scope, because I've also added testing with lowest/locked/latest dependencies. Usually we bump to the latest version (which contain all updates - and previous version was not LTS) to force users to use versions with all fixes. I think we should then have these dependencies bump here. Otherwise we can find many things to split this PR into multiple smaller PRs, but what is the point?
There was a problem hiding this comment.
Updating minimum versions for those packages is unrelated to either of 1) phpunit 2) php version bump 3) coding style fixes 4) travis, unless they were failing with new test setup.
Hence it is outside of the scope of this PR.
Anyway, disregard that.
test/Client/CommonHttpTests.php
Outdated
| @@ -47,17 +49,17 @@ | |||
| /** | |||
| * Common HTTP client | |||
| * | |||
| * @var \Zend\Http\Client | |||
| * @var Client | |||
There was a problem hiding this comment.
it is already imported as HTTPClient, no need for another use
- per @Xerkus
PHPUnit ^6.0 || ^5.7 - Updated all tests to support both versions.
Added docheader tool to checks all license headers and update headers in all files.
Updated composer scripts and CONTRIBUTING to refer these scripts.
Updated travis configuration to run tests with lowest/locked/latest dependencies on PHP 5.6/7.0/7.1.
Dropped PHP 5.5 support.
Many CS fixes (fixed indents, array trailing commas, double quotes, formatting)