This repository was archived by the owner on Jan 30, 2020. It is now read-only.
PhpEnvironment\Request::detectBaseUrl() - E_WARNING: strpos(): Empty needle #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your diagnosis is off. The conditionals in line 498 are correct; what needs to happen is for line 522 to check for a non-empty if (! empty($baseUrl) && 0 === strpos($requestUri, $baseUrl)) {I'll work on a test for this shortly. |
If the SCRIPT_FILENAME and SCRIPT_NAME are empty, prior to this patch, an E_WARNING will be raised when we attempt to do a `strpos()` using the now empty `$baseUrl`. This patch adds a test for that, and also a conditional prior to the `strpos()` to return early if `$baseUrl` is empty.
|
I've converted this issue with a pull request, which adds a test for the condition (it failed prior to the patch), and a patch to ensure the condition does not occur. |
weierophinney
added a commit
that referenced
this pull request
Aug 5, 2015
weierophinney
added a commit
that referenced
this pull request
Aug 5, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think those checks on following lines https://github.com/zendframework/zend-http/blob/master/src/PhpEnvironment/Request.php#L498 should use
empty()instead of!== nullbecause in some cases it triggers warning on a line:https://github.com/zendframework/zend-http/blob/master/src/PhpEnvironment/Request.php#L522