This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Allow usage of v3 releases of zend-eventmanager and zend-stdlib #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The APIs consumed from each are identical between versions, allowing the component to target either. One change was required, however: `Zend\Ldap\Node` needed slight changes to how it marshals an `EventManager` instance to ensure it works across both versions.
Since this patch is specifying two different series of releases, we need to ensure we test against them all. As such, this introduces: - composer.lock file - composer scripts for testing, CS, and coverage uploads - travis configuration to test each PHP version against lowest, locked, and latest.
- Removed trailing comma.
|
Thanks for the work! This makes handling the failing test to a top priority. That might delay tagging the 2.7 release but I believe that should be fixed before we get this into a new release! |
|
@heiglandreas My pleasure. Good luck with that test. 😄 |
| null, | ||
| 'No LDAP connection specified.', | ||
| Exception\LdapException::LDAP_OTHER | ||
| ); |
There was a problem hiding this comment.
These fixes were because phpcs was giving me grief about multiple arguments. I figured I'd go ahead and fix them.
There was a problem hiding this comment.
I already thought so and it definitely improves readability!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces #42.
This patch updates the dependency constraints as follows:
^5.5 || ^7.0, putting it in line with other components. That said, I'm aware of PHP 7 differences that currently mean tests do not pass (due to changes in sorting behavior).^2.6 || ^3.0Zend\Ldap\Nodeto ensure that a lazy-loadedEventManagerinstance is created in a way that works against both major versions.^2.7 || ^3.0To ensure that the component works against each set of releases, this patch also updates the travis configuration to test against lowest supported verions, a lockfile, and latest versions.