Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Conversation

mleko
Copy link
Contributor

@mleko mleko commented Apr 19, 2016

No description provided.

@Maks3w
Copy link
Member

Maks3w commented Apr 19, 2016

Please, add the descriptions too as appear on Address

/**
* Retrieve email
*
* @return string
*/
public function getEmail()
{
return $this->email;
}
/**
* Retrieve name
*
* @return string
*/
public function getName()
{
return $this->name;
}
/**
* String representation of address
*
* @return string
*/

@CarwynNelson
Copy link

Surely the method names should be enough documentation? This just seems to be re-typing what the method name is already telling us it does.

@weierophinney weierophinney added this to the 2.7.1 milestone May 5, 2016
@weierophinney weierophinney self-assigned this May 5, 2016
@weierophinney weierophinney merged commit b2f2ea4 into zendframework:master May 5, 2016
weierophinney added a commit that referenced this pull request May 5, 2016
weierophinney added a commit that referenced this pull request May 5, 2016
weierophinney added a commit that referenced this pull request May 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants