This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
[BC break] Remove old InjectTemplateListener behavior #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitelisted classname based template name resolution from ^2.3.0 is now default Template resolution follows these rules: 1. strip \Controller\ namespace if present 2. strip trailing Controller in classname 3. inflect CamelCase to dash 4. replace namespace separator with slash @see zendframework/zendframework#5670
Xerkus
changed the title
|
@Xerkus Could you please add some verbiage into Thanks! |
|
@Xerkus You can even leave a comment on the issue if you want, and I can then draft up the migration doc changes. |
weierophinney
added a commit
that referenced
this pull request
May 31, 2016
…ver-behavior [BC break] Remove old InjectTemplateListener behavior
weierophinney
added a commit
that referenced
this pull request
May 31, 2016
weierophinney
added a commit
that referenced
this pull request
May 31, 2016
weierophinney
added a commit
that referenced
this pull request
May 31, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed old pseudomodule template name resolution which ignored subnamespaces and used
__NAMESPACE__variable in convoluted and non-intuitive ways.Whitelisted classname based template name resolution introduced in
^2.3.0is now defaultTemplate resolution follows these rules:
\Controller\namespace if presentControllerin classname, unless classname is exactlyControllerSee zendframework/zendframework#5670
This breaks backwards compatibility in some cases, check couple changed tests.
Affected modules can achieve compatibility with v2 and v3 simultaneously by adding whitelist entry to template map and moving templates or by mapping namespace to old location.
Needs documentation. If anyone is willing to write it for me I definitely won't object to that