Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Conversation

freax
Copy link
Contributor

@freax freax commented Jul 17, 2015

It's pretty confusing to use the same variable name that function parameter (especially you have different highlight for parameter variables in your IDE).
This PR makes write-function more readable.

@mwillbanks
Copy link
Contributor

I understand why you are stating that, however, you are actually now creating a copy that will yield another variable that needs to be cleaned up by the garbage collector. However, I actually find this less readable but it is subjective to whomever might be viewing it. Leveraging the same variable name is often a practice of conserving memory. Imagine my session data contained very large data (it's not common but I see it happen in practice). Overall, I do not believe that this is a useful change at this point in time.

@mwillbanks mwillbanks closed this Jul 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants