This repository was archived by the owner on Jan 31, 2020. It is now read-only.
phpunit update #74
Merged
phpunit update #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kokspflanze
commented
Mar 28, 2017
kokspflanze
commented
- PHPUnit_Framework_TestCase to PHPUnit\Framework\TestCase
- changed setExpectedException method to expectException, expectExceptionMessage
- fix "This test did not perform any assertions"
- @requires PHP 5.4 removed
- removed old PHPUnit_Runner_Version case
- changed phpunit 4 to 5.7/6 in composer
- added composer.lock
- removed composer.lock in gitignore
- travis process update
- added php 7.1 in travis
added composer.lock removed composer.lock in gitignore
also added composer.lock in .gitattributes
added php 7.2 and removed old parts, which now handle the zfbot
.travis.yml
Outdated
| - if [[ $TEST_COVERAGE == 'true' ]]; then composer upload-coverage ; fi | ||
|
|
||
| notifications: | ||
| email: false |
There was a problem hiding this comment.
Please add one empty line at the end of the file
There was a problem hiding this comment.
added, didnt saw it in the template, i didnt checkout the repo
test/ArrayUtilsTest.php
Outdated
|
|
||
| /** | ||
| * @expectedException \Zend\Stdlib\Exception\InvalidArgumentException | ||
| * @expectedException InvalidArgumentException |
There was a problem hiding this comment.
Just for consistency I would change it to method call instead of PHPDoc tag.
michalbundyra
approved these changes
Aug 24, 2017
|
@kokspflanze |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.