This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Provide forward compatibility with v3 where functionality is broken #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V3 Compatibility
Updates the FlashMessenger to be forwards compatible with zendframework/zend-mvc-plugin-flashmessenger, while retaining compatibility with zend-mvc 2.7. This required: - Removing references to class constants defined in the FlashMessenger MVC plugin; this means temporarily hardcoding the values in the helper, and resulted in a TODO item to re-introduce them for version 3. - Removing typehints for the FlashMessenger MVC plugin; when required, we now test against both the v2 and v3 class name to validate. - Deprecating the helper for version 3.0.
weierophinney
changed the title
zend-router is always required, so we need to check for the absence of v2 routing classes before injecting zend-router configuration. Similarly, in the `UrlTest`, we need to set the types to test against based on presence of v2 routing classes, not v3 routing classes.
|
WE HAVE GREEN!!!! |
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates zend-view to be forwards compatible with zend-mvc v3.
UrlHelper
The UrlHelper tests were previously using typehints against the zend-mvc v2 router in some locations. This patch provides updates to the test to detect which router version is present, as well as which route classes, so it can test correctly across both router versions.
Navigation helpers
The navigation helper tests were:
They have been updated to resolve this, and now pass against both versions.
FlashMessenger
Updates the FlashMessenger to be forwards compatible with zendframework/zend-mvc-plugin-flashmessenger, while retaining compatibility with zend-mvc 2.7. This required:
This PR supercedes #78.