Separate linting from unit-tests #2316
Conversation
…o/zenml into feature/OSSK-324-fast-ci-slow-ci
* give darglint check its own job * fastCI * add slowCI * reenable fast CI * remove comment * add integration tests * fix spellcheck context * enable slow CI for testing * remove unit test dependency * fix dependency installations * yamlfixed * Comment-driven CI (#2275) * test comment-driven approach * delete unused test file * slow CI is comment-driven * restore CI * conditionally respond to comments depending on team status * add the whole team * Update .github/workflows/ci-slow.yml Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> --------- Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * delete old CI --------- Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
Add custom-ubuntu-setup-and-unit-test workflow Update unit-test workflow Remove lint check from unit-test workflow
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe project's GitHub workflows have been updated to separate linting from unit testing. A new job and workflow specific to linting on Ubuntu with Python 3.10 has been introduced, while the unit testing workflow no longer includes linting steps and has some default parameter adjustments. Debugging capabilities have been added to the linting workflow with tmate. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…-linting-from-unit-test
github-actions
bot
added
internal
|
@coderabbitai review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: .coderabbit.yaml
Files selected for processing (3)
- .github/workflows/ci-fast.yml (1 hunks)
- .github/workflows/linting.yml (1 hunks)
- .github/workflows/unit-test.yml (3 hunks)
Additional comments: 2
.github/workflows/unit-test.yml (1)
- 2-2: The workflow name has been updated to reflect the removal of the linting step.
.github/workflows/ci-fast.yml (1)
- 51-62: A new job
custom-ubuntu-setup-and-linthas been added to handle linting separately. Ensure that this job is correctly referenced and that the conditions for running it are appropriate.
.github/workflows/unit-test.yml
Outdated
| - name: Setup tmate session before tests | ||
| if: ${{ inputs.enable_tmate == 'before-tests' }} | ||
| uses: mxschmitt/action-tmate@v3.17 | ||
| - name: Lint check | ||
| env: | ||
| OS: ${{ inputs.os }} | ||
| run: | | ||
| bash scripts/lint.sh | ||
| - name: Run unit tests | ||
| run: | | ||
| bash scripts/test-coverage-xml.sh unit | ||
|
|
||
| # - name: Upload coverage | ||
| # # only do it for python 3.8, we don't need to do it for every version | ||
| # if: ${{ inputs.os == 'ubuntu-dind-runners' && inputs.python-version == '3.8' }} |
There was a problem hiding this comment.
Tip
Codebase Verification
The search for codecov/codecov-action within the .github/workflows/ directory indicates that the action is commented out in both unit-test.yml and linting.yml. This suggests that coverage uploading has been disabled in these workflows. There is no evidence from the provided output that coverage data is being uploaded in any other part of the workflow files.
Analysis chain
Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [58-108]
The linting steps have been removed, and the comments related to uploading coverage have also been deleted. Ensure that coverage data is either not required anymore or is being handled elsewhere.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that coverage uploading is handled in another workflow or is no longer needed.
rg --type yaml "codecov/codecov-action" .github/workflows/
Length of output: 204
* add pytest-shard dev dependency * update script for sharded testing * add ubuntu sharding * fix naming * Use `pytest-split` to shard CI (#2296) * add split test to action * Update user authentication logic * Fix bug in login functionality * Refactor test coverage script * Update excluded directories in pyproject.toml * Update integration test script to include shard number * Update integration test script to use matrix.shard * Update caching key in setup_environment action.yml * Update durations path in test-coverage-xml.sh * Update cache key in setup_environment action.yml * Auto-update of Starter template * Fix formatting issue in setup_environment action.yml * Refactor code to improve performance and readability --------- Co-authored-by: GitHub Actions <actions@github.com> * Update pyproject.toml Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com> * add extra final line * make workflows use normal ubuntu) * fix durations path and update docstring --------- Co-authored-by: Safoine El Khabich <34200873+safoinme@users.noreply.github.com> Co-authored-by: GitHub Actions <actions@github.com>
…o/zenml into feature/OSSK-324-fast-ci-slow-ci
…-linting-from-unit-test
…zenml-io/zenml into feature/seperate-linting-from-unit-test
…-linting-from-unit-test
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes
Summary by CodeRabbit