-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated methods #462
Deprecated methods #462
Conversation
👍, but where are the tests? |
Great, another PR that no one reviews... |
Andres didn't answer to my emails and messages on hangout @nkt I didn't add tests because i w8
@nkt Not a problem I can w8 reviewers but if I see answers for my messages first! @phalcon |
So basically, you added these changes without reviewing because unrelated messages are without answer? |
@phalcon |
anyway guys 👍 keep calm and good job! |
Again, I can't understand why is that related, the rule is simple, you wait for someone to review before merging the PRs into the repository |
Added missing tests for deprecated modifier #462
|
No description provided.