Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated methods #462

Merged
merged 2 commits into from Jul 26, 2014
Merged

Deprecated methods #462

merged 2 commits into from Jul 26, 2014

Conversation

@ovr
Copy link
Contributor

@ovr ovr commented Jul 26, 2014

No description provided.

ovr added a commit that referenced this pull request Jul 26, 2014
@ovr ovr merged commit 386ce55 into zephir-lang:master Jul 26, 2014
1 check passed
1 check passed
@ovr
continuous-integration/travis-ci The Travis CI build passed
Details
@nkt
Copy link
Contributor

@nkt nkt commented Jul 26, 2014

👍, but where are the tests?

@ghost
Copy link

@ghost ghost commented Jul 26, 2014

Great, another PR that no one reviews...

@nkt
Copy link
Contributor

@nkt nkt commented Jul 26, 2014

@phalcon, 👍
@ovr wait for review from someone, let's do not merge self-posted PRs

@ovr
Copy link
Contributor Author

@ovr ovr commented Jul 26, 2014

Andres didn't answer to my emails and messages on hangout
Nikolaos didn't answer in hangout.
@phalcon didn't answer who is sitting under him
Noone didn't answer about migration this project to zephir-lang

@nkt I didn't add tests because i w8 457_issus branch

ovr@aad6e0c

$this->getReflection()->getMethod($this->getName())->isDeprecated()

@nkt
У тебя есть мой скайп начни просто отвечать на сообщения и писать "что Дима где тесты!?", а я тебе отвечу почему тестов нет.

Not a problem I can w8 reviewers but if I see answers for my messages first!

@phalcon
You can remove me from collaborator`s group if I am really doing something bad at the current moment

@ghost
Copy link

@ghost ghost commented Jul 26, 2014

So basically, you added these changes without reviewing because unrelated messages are without answer?

@ovr
Copy link
Contributor Author

@ovr ovr commented Jul 26, 2014

@phalcon
Yeah, because I am not interested to wait you review if you can't answer my messages
And most of all pull requests you didn't say anything after review
How can I understand that you reviewed pull request?

@lukaszlach
Copy link

@lukaszlach lukaszlach commented Jul 26, 2014

anyway guys 👍 keep calm and good job!

@ghost
Copy link

@ghost ghost commented Jul 26, 2014

Yeah, because I am not interested to wait you review if you can't answer my messages

Again, I can't understand why is that related, the rule is simple, you wait for someone to review before merging the PRs into the repository

ovr added a commit that referenced this pull request Jul 26, 2014
Added missing tests for deprecated modifier #462
@ovr
Copy link
Contributor Author

@ovr ovr commented Jul 27, 2014

@phalcon
Yeah, because I am not interested to wait you review if you can't answer my messages
And most of all pull requests you didn't say anything after review

@phalcon
You can remove me from collaborator`s group if I am really doing something bad at the current moment

@phalcon didn't answer who is sitting under him!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants