Skip to content

Conversation

Ayush1325
Copy link
Member

@Ayush1325 Ayush1325 commented Jun 8, 2024

  • A basic sync implementation

@Ayush1325 Ayush1325 force-pushed the pulsein branch 2 times, most recently from bd94398 to 96b6e8a Compare June 10, 2024 10:47
@Ayush1325 Ayush1325 force-pushed the pulsein branch 3 times, most recently from bc4ecbc to 3baf23b Compare June 14, 2024 16:40
Copy link
Member

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, with the minor suggestions we should be ok.

@Ayush1325
Copy link
Member Author

Ayush1325 commented Jun 19, 2024

@DhruvaG2000 Any idea regarding the failing CI? I don't think it is related to this PR.

@DhruvaG2000
Copy link
Member

@DhruvaG2000 Any idea regarding the failing CI?

Yep, locally reproduced just now.
/__w/gsoc-2022-arduino-core/gsoc-2022-arduino-core/Arduino-Zephyr-API/samples/i2cdemo/prj.conf:2: warning: attempt to assign the value 'y' to the undefined symbol CPLUSPLUS

Need to get rid of this symbol from everywhere looks like.

@DhruvaG2000
Copy link
Member

Not related to this PR, so nothing to be alarmed.

@DhruvaG2000
Copy link
Member

This PR should probably help:
#104

- A basic sync implementation
- Use ticks for better resolution

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@DhruvaG2000 DhruvaG2000 merged commit 3674743 into zephyrproject-rtos:next Jun 19, 2024
@Ayush1325 Ayush1325 deleted the pulsein branch June 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants