samples: hello arduino: Clean up #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup hello_arduino sample by removing comments that no longer apply and also removing unnecessary amount of prints. Signed-off-by: Dhruva Gole <goledhruva@gmail.com>
soburi
reviewed
Dec 21, 2022
There was a problem hiding this comment.
It is good as "hello world" example.
The original was also work as formatting test.
Is not need to consider?
(Such like as https://www.arduino.cc/reference/en/language/functions/communication/serial/print/.)
I agree that we should have a way to demo other Serial.print variants as well. |
|
Closing this- because this sample actually demonstrates a lot of useful stuff that our API can do so let's keep as is. |
Closed
soburi
pushed a commit
to soburi/gsoc-2022-arduino-core
that referenced
this pull request
Sep 24, 2025
This is a replacement for PR: zephyrproject-rtos#71 and zephyrproject-rtos#82. All of the earlier commits were squashed into one. Then this was converted a few times during the zephyrproject-rtos#85 pr time frame as things kept changing and moving around. It has now been updated to the released .3 version. We defined the additional SPI ports and Wire ports. We defined an initial setup for Analog pins. Have similar hack to GIGA version for pure Analog. Added additional hacks for duplicated pins. That is two of the analog Pins are the exact same pin as some other digital pins... Added some PWM support. Also added WIP: camera support. Co-Authored-By: Mike S <5366213+mjs513@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup hello_arduino sample by removing comments that no longer apply and also removing unnecessary amount of prints.
Closes #38
Signed-off-by: Dhruva Gole goledhruva@gmail.com