zephyrSerial: Fix misdetection arduino_serial1 #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DT_NODE_EXISTS value is true even if the status is disabled, so it caused misdetection. Use DT_NODE_HAS_STATUS to detect the status of the arduino_serial1 node is ok.
soburi
force-pushed
the
correct_arduino_serial1
branch
from
e9e69ac to
363f134
Compare
soburi
changed the title
|
Hi, thanks for the quick fix @soburi , I'll test in sometime and merge this if it looks okay. |
DhruvaG2000
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DT_NODE_EXISTS value is true even if the status is disabled, so it caused misdetection.
Use DT_NODE_HAS_STATUS to detect the status of
the arduino_serial1 node is ok.
Fix #77