Skip to content

Conversation

nhutnguyenkc
Copy link
Contributor

Add HAL FSP DMA files to support DMA driver for RZ/A, V, T, N series

@KhiemNguyenT
Copy link
Collaborator

@khoa-nguyen-18 please take a look.

Comment on lines 91 to 104

* Use r_transfer_api.h of rzv-fsp to support the callbackSet member of the transfer_api_t struct
Impacted files:
drivers/rz/fsp/inc/api/r_transfer_api.h

* Change the cast type from uint32_t to uintptr_t when assigning an address to a register in the
DMAC FSP driver of the RZ/A3UL to avoid build warnings
Impacted files:
drivers/rz/fsp/src/rza/r_dmac/r_dmac.c

* Disable the BSP_FEATURE_BSP_HAS_MMU_SUPPORT configuration of the RZ/A3UL to avoid using
FSP MMU functions
Impacted files:
drivers/rz/fsp/src/rza/bsp/mcu/rza3ul/bsp_feature.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate these updates into other commits to make them easier to track

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already, please help me check those commits. There are 4 commits for each

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the RA side, we separate any changes that modify the original FSP source into a different commit, separate from the commit that adds support.

My suggestion is that, in addition to the 4 commits where you add support, please create other commits specifically for these change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have split these changes into separate commits. Please help me check again.

#define BSP_FEATURE_BSP_SUPPORT_PLL5_CONFIG (0U)
#define BSP_FEATURE_BSP_SUPPORT_OCTAL_MEMORY (1U)
#define BSP_FEATURE_BSP_HAS_MMU_SUPPORT (1)
#define BSP_FEATURE_BSP_HAS_MMU_SUPPORT (0U)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the reason for changing this value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is to let Zephyr handle MMU functionality. Therefore, the BSP_FEATURE_BSP_HAS_MMU_SUPPORT configuration is disabled to avoid porting r_mmu module from FSP.

Hieu Nguyen added 7 commits September 30, 2025 14:57
Use r_transfer_api.h of rzv-fsp to support the callbackSet
member of the transfer_api_t struct

Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com>
Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add HAL FSP DMAC_B files to support DMA for RZ/V series

Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com>
Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add HAL FSP DMAC files to support DMA for RZ/A series

Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com>
Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Disable the BSP_FEATURE_BSP_HAS_MMU_SUPPORT configuration of the RZ/A3UL
to let Zephyr handle MMU

Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com>
Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Change the cast type from uint32_t to uintptr_t when assigning
an address to a register in the DMAC FSP driver of the RZ/A3UL
to avoid build warnings

Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com>
Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add HAL FSP DMAC files to support DMA for RZ/T series

Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com>
Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add HAL FSP DMAC files to support DMA for RZ/N series

Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com>
Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Copy link
Contributor

@khoa-nguyen-18 khoa-nguyen-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants