-
Notifications
You must be signed in to change notification settings - Fork 19
hal: renesas: rz: Add DMA support for RZ/A, V, T, N series #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
hal: renesas: rz: Add DMA support for RZ/A, V, T, N series #146
Conversation
5927e05
to
54051ed
Compare
@khoa-nguyen-18 please take a look. |
drivers/rz/README
Outdated
|
||
* Use r_transfer_api.h of rzv-fsp to support the callbackSet member of the transfer_api_t struct | ||
Impacted files: | ||
drivers/rz/fsp/inc/api/r_transfer_api.h | ||
|
||
* Change the cast type from uint32_t to uintptr_t when assigning an address to a register in the | ||
DMAC FSP driver of the RZ/A3UL to avoid build warnings | ||
Impacted files: | ||
drivers/rz/fsp/src/rza/r_dmac/r_dmac.c | ||
|
||
* Disable the BSP_FEATURE_BSP_HAS_MMU_SUPPORT configuration of the RZ/A3UL to avoid using | ||
FSP MMU functions | ||
Impacted files: | ||
drivers/rz/fsp/src/rza/bsp/mcu/rza3ul/bsp_feature.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please separate these updates into other commits to make them easier to track
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already, please help me check those commits. There are 4 commits for each
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the RA side, we separate any changes that modify the original FSP source into a different commit, separate from the commit that adds support.
My suggestion is that, in addition to the 4 commits where you add support, please create other commits specifically for these change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have split these changes into separate commits. Please help me check again.
#define BSP_FEATURE_BSP_SUPPORT_PLL5_CONFIG (0U) | ||
#define BSP_FEATURE_BSP_SUPPORT_OCTAL_MEMORY (1U) | ||
#define BSP_FEATURE_BSP_HAS_MMU_SUPPORT (1) | ||
#define BSP_FEATURE_BSP_HAS_MMU_SUPPORT (0U) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain the reason for changing this value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is to let Zephyr handle MMU functionality. Therefore, the BSP_FEATURE_BSP_HAS_MMU_SUPPORT configuration is disabled to avoid porting r_mmu module from FSP.
Use r_transfer_api.h of rzv-fsp to support the callbackSet member of the transfer_api_t struct Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add HAL FSP DMAC_B files to support DMA for RZ/V series Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add HAL FSP DMAC files to support DMA for RZ/A series Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Disable the BSP_FEATURE_BSP_HAS_MMU_SUPPORT configuration of the RZ/A3UL to let Zephyr handle MMU Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Change the cast type from uint32_t to uintptr_t when assigning an address to a register in the DMAC FSP driver of the RZ/A3UL to avoid build warnings Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add HAL FSP DMAC files to support DMA for RZ/T series Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
Add HAL FSP DMAC files to support DMA for RZ/N series Signed-off-by: Hieu Nguyen <hieu.nguyen.ym@bp.renesas.com> Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
54051ed
to
bd874a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me
Add HAL FSP DMA files to support DMA driver for RZ/A, V, T, N series