cmake: add --divide to GNU assembler options for x86 #20229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNU Assembler, by default on non-Linux targets, treats slashes as start of comments on i386. (https://sourceware.org/binutils/docs-2.33.1/as/i386_002dChars.html#i386_002dChars) In order to use division, `--divide` needs to be passed to the assembler. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
galak
approved these changes
Oct 30, 2019
wentongwu
approved these changes
Oct 30, 2019
andrewboie
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU Assembler, by default on non-Linux targets, treats slashes as
start of comments on i386.
(https://sourceware.org/binutils/docs-2.33.1/as/i386_002dChars.html#i386_002dChars)
In order to use division,
--divideneeds to be passed tothe assembler.
Fixes zephyrproject-rtos/sdk-ng#109