doc: add test coverage and proposal policy #6546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6546 +/- ##
==========================================
+ Coverage 53.08% 53.45% +0.37%
==========================================
Files 430 437 +7
Lines 41040 41390 +350
Branches 7908 7934 +26
==========================================
+ Hits 21785 22127 +342
- Misses 16032 16043 +11
+ Partials 3223 3220 -3
Continue to review full report at Codecov.
|
dbkinder
suggested changes
Mar 10, 2018
CONTRIBUTING.rst
Outdated
| @@ -566,6 +566,34 @@ Other Commit Expectations | |||
| proposals, progress snapshots of your work, or to get early feedback on | |||
| features or changes that will affect multiple areas in the code base. | |||
|
|
|||
| * When major new functionality is added, tests for the new functionality MUST be | |||
| added to the automated test suite. All new APIs MUST be documented and tested | |||
| and test MUST cover at least 80% of the added functionality using the code | |||
There was a problem hiding this comment.
s/test/tests/ or maybe testing
| You can request a new feature or submit a proposal by submitting an issue to | ||
| our GitHub Repository. | ||
| If you would like to implement a new feature, please submit an issue with a | ||
| proposal (RFC) for your work first, to be sure that we can use it. Please |
There was a problem hiding this comment.
maybe mention adding RFC: to the title of the issue?
There was a problem hiding this comment.
detailed howto for proposal will follow.
Provide some details about submitting proposals and document that new major features require tests to be added. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
|
@dbkinder updated |
dbkinder
approved these changes
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide some details about submitting proposals and document that new
major features require tests to be added.
Signed-off-by: Anas Nashif anas.nashif@intel.com