Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add test coverage and proposal policy #6546

Merged
merged 1 commit into from Mar 11, 2018

Conversation

@nashif
Copy link
Member

@nashif nashif commented Mar 10, 2018

Provide some details about submitting proposals and document that new
major features require tests to be added.

Signed-off-by: Anas Nashif anas.nashif@intel.com

@nashif nashif requested a review from dbkinder as a code owner Mar 10, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 10, 2018

Codecov Report

Merging #6546 into master will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6546      +/-   ##
==========================================
+ Coverage   53.08%   53.45%   +0.37%     
==========================================
  Files         430      437       +7     
  Lines       41040    41390     +350     
  Branches     7908     7934      +26     
==========================================
+ Hits        21785    22127     +342     
- Misses      16032    16043      +11     
+ Partials     3223     3220       -3
Impacted Files Coverage Δ
subsys/net/ip/route.c 52.99% <0%> (-0.23%) ⬇️
subsys/net/ip/ipv6.c 23.72% <0%> (-0.2%) ⬇️
subsys/net/ip/6lo.c 29.21% <0%> (-0.15%) ⬇️
subsys/net/ip/l2/ieee802154/ieee802154_fragment.c 2.5% <0%> (-0.02%) ⬇️
subsys/net/ip/net_context.c 60.3% <0%> (ø) ⬆️
include/posix/pthread.h 100% <0%> (ø) ⬆️
subsys/net/ip/ipv6.h 100% <0%> (ø) ⬆️
subsys/net/lib/http/http.c 0% <0%> (ø) ⬆️
subsys/bluetooth/host/hci_core.c 2.11% <0%> (ø) ⬆️
tests/kernel/timer/timer_api/src/main.c 66.66% <0%> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a6d93...56af75b. Read the comment docs.

CONTRIBUTING.rst Outdated
@@ -566,6 +566,34 @@ Other Commit Expectations
proposals, progress snapshots of your work, or to get early feedback on
features or changes that will affect multiple areas in the code base.

* When major new functionality is added, tests for the new functionality MUST be
added to the automated test suite. All new APIs MUST be documented and tested
and test MUST cover at least 80% of the added functionality using the code
Copy link
Contributor

@dbkinder dbkinder Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/test/tests/ or maybe testing

You can request a new feature or submit a proposal by submitting an issue to
our GitHub Repository.
If you would like to implement a new feature, please submit an issue with a
proposal (RFC) for your work first, to be sure that we can use it. Please
Copy link
Contributor

@dbkinder dbkinder Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mention adding RFC: to the title of the issue?

Copy link
Member Author

@nashif nashif Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detailed howto for proposal will follow.

Provide some details about submitting proposals and document that new
major features require tests to be added.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
Copy link
Member Author

@nashif nashif commented Mar 11, 2018

@dbkinder updated

@nashif nashif merged commit a706a68 into zephyrproject-rtos:master Mar 11, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants