drivers: led: refactor lp5562 into lp55xx, and add support for 5521 #78968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
led_data variable values are constant, why not use macros instead this will simplify code and reduces memory usage Signed-off-by: Anuj Pathak <anuj@croxel.com>
cx-anuj-pathak
force-pushed
the
drivers/led/lp55xx
branch
2 times, most recently
from
25fe2b2 to
bbabc67
Compare
Refactor source handling to generic APIs to enter PWM/Enginge mode. This will enable the path toward merging lp5521 driver. Signed-off-by: Anuj Pathak <anuj@croxel.com>
- Since we'll merge lp5562 and lp5521, where both have different color ordering, lets use standard color ids This will also enable us in merging lp5521 driver - Fixed lp5562 sample to use ColorIDs Signed-off-by: Anuj Pathak <anuj@croxel.com>
generalized handling of current settings and default state on init driver is now ready to rename and merge Signed-off-by: Anuj Pathak <anuj@croxel.com>
Define and use interface structure to handle the differnce between lp5562 and lp5521 drivers Signed-off-by: Anuj Pathak <anuj@croxel.com>
- updated correspoding kconf and CMake Signed-off-by: Anuj Pathak <anuj@croxel.com>
- added lp5562, lp5521 dts defintion extending lp55xx base Signed-off-by: Anuj Pathak <anuj@croxel.com>
renamed all refereces to 5562 to 55xx which are same for both 5562 and 5521 Signed-off-by: Anuj Pathak <anuj@croxel.com>
- implemented lp5521 interface in lp55xx driver - updated KConfig to enable LP5521 support Signed-off-by: Anuj Pathak <anuj@croxel.com>
cx-anuj-pathak
force-pushed
the
drivers/led/lp55xx
branch
from
bbabc67 to
b4fd492
Compare
zephyrbot
added
platform: TI SimpleLink
zephyrbot
requested review from
bbilas,
kartben,
Mani-Sadhasivam,
nashif,
simonguinot,
vaishnavachath and
vanti
Add support for testing of lp5521 using threads Signed-off-by: Anuj Pathak <anuj@croxel.com>
We were using individual function for programing a instructions. This is inefficient as we are making too much I2C calls. This commit introduced macros to generate complete program bytes, and used burst write to write complete program in one I2C call This commit also incroduce load_and_run API to simplify update blink brightness and blink APIs Signed-off-by: Anuj Pathak <anuj@croxel.com>
- add croxel_cx1825 board to platform_allow list of lp55xx sample Signed-off-by: Anuj Pathak <anuj@croxel.com>
cx-anuj-pathak
force-pushed
the
drivers/led/lp55xx
branch
from
b4fd492 to
8f20892
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors lp5562 driver into lp55xx, and add support for LP5521 LED driver.