pm: Fix to prevent incorrect forever timeout #93114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K_TICKS_FOREVER is defined as -1. Guard logic has been added for the case when `ticks - exit_latency_ticks == -1` to prevent sys_clock_set_timeout() from incorrectly setting a forever timeout. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
github-actions
bot
requested review from
bjarki-andreasen,
ceolin,
JordanYates,
nashif and
teburd
serhiy-katsyuba-intel
requested review from
abonislawski
and removed request for
teburd,
nashif,
ceolin,
JordanYates and
bjarki-andreasen
|
bjarki-andreasen
approved these changes
Jul 14, 2025
abonislawski
approved these changes
Jul 15, 2025
softwarecki
approved these changes
Jul 15, 2025
tmleman
approved these changes
Jul 15, 2025
nashif
approved these changes
Jul 15, 2025
teburd
approved these changes
Jul 15, 2025
danieldegrasse
added
the
backport v4.2-branch
kartben
added
area: ARM64
|
Does this fix really work? Coverity complains that the signed and unsigned mix up in the subtraction makes the whole thing moot: https://scan9.scan.coverity.com/#/project-view/61616/12996?selectedIssue=535628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K_TICKS_FOREVER is defined as -1. Guard logic has been added for the case when
ticks - exit_latency_ticks == -1to prevent sys_clock_set_timeout() from incorrectly setting a forever timeout.