boards: add steelseries apexpromini #95905

everedero · 2025-09-12T11:30:12Z

Initial support for the Apex Pro Mini keyboard,
based on STM32L412.

nordicjm

this board has hwmv1 remnants that need to go

boards/steelseries/apexpromini/apexpromini.dts

nordicjm · 2025-09-12T11:50:23Z

boards/steelseries/apexpromini/apexpromini_defconfig

+# Enable HW stack protection
+CONFIG_HW_STACK_PROTECTION=y
+
+# enable uart driver


capitalise first letters of comments

nordicjm · 2025-09-12T11:50:34Z

boards/steelseries/apexpromini/apexpromini_defconfig

+# enable USB
+CONFIG_USB_DEVICE_STACK_NEXT=y
+CONFIG_CDC_ACM_SERIAL_INITIALIZE_AT_BOOT=y
+CONFIG_USBD_CDC_ACM_LOG_LEVEL_OFF=y
+
+# enable input keyboard matrix
+CONFIG_INPUT=y
+CONFIG_INPUT_KEYMAP=y
+CONFIG_INPUT_GPIO_KBD_MATRIX=y
+# Required because rows are actually columns
+CONFIG_INPUT_KBD_MATRIX_16_BIT_ROW=y
+
+# enable spi flash
+CONFIG_FLASH=y
+CONFIG_SPI_NOR_FLASH_LAYOUT_PAGE_SIZE=4096


none of this is needed?

Well, it does not have a debug LED or an UART port, it just has a USB port and some keys, so it feels weird to let them be optional features. But maybe they should be anyway?

If it has USB then CDC ACM as the console by default is ok, the rest though is not

On this board, USB will not work without CDC_ACM_SERIAL_INITIALIZE_AT_BOOT, and KBD_MATRIX will not work without INPUT_KBD_MATRIX_16_BIT_ROW. Is there a wait to enforce or to document those dependencies?

the USB ones can stay, the kbd one can be done in Kconfig.defconfig a pseudo example:

if BLAH config BLAH_OTHER default SOMETHING endif # BLAH

decsny · 2025-09-15T18:09:23Z

@nashif maybe you can help review since you had your opinions about vendor-prefixes.txt being so important

fabiobaltieri · 2025-09-15T20:14:07Z

boards/steelseries/apexpromini/apexpromini.dts

+};
+
+&kbd {
+	keymap {


you can put this straight under the kbd node on line 69 if you want to, no point shuffling nodes around

kartben · 2025-09-15T19:47:25Z

boards/steelseries/apexpromini/doc/index.rst

+.. _apexpromini_board:
+
+SteelSeries ApexProMini
+#######################


Suggested change

#######################

.. zephyr:board:: apexpromini

kartben · 2025-09-15T19:49:35Z

boards/steelseries/apexpromini/board.yml

+  name: apexpromini
+  full_name: SteelSeries Apex Pro Mini


So it does look like official product name is indeed "Apex Pro Mini" (with spaces) so please use the same spelling everywhere.
Also, given there are spaces, i think apex_pro_mini might be a better suited board name?
Finally, vendor name can be ommited in the board "full name"

Suggested change

name: apexpromini

full_name: SteelSeries Apex Pro Mini

name: apex_pro_mini

full_name: Apex Pro Mini

kartben · 2025-09-15T20:10:48Z

boards/steelseries/apexpromini/doc/index.rst

can you check line wrapping in this file and make it consistent? there's a mix of very aggressive (< 80 characters) and no wrapping at all currently :) 100 characters per line would be good. Thanks!

boards/steelseries/apex_pro_mini/doc/index.rst

fabiobaltieri · 2025-09-16T14:23:18Z

boards/steelseries/apex_pro_mini/Kconfig.defconfig

+	if INPUT_GPIO_KBD_MATRIX
+
+	config INPUT_KBD_MATRIX_16_BIT_ROW
+		default y
+
+	endif # INPUT_GPIO_KBD_MATRIX
+
+	if FLASH
+
+	config SPI_NOR_FLASH_LAYOUT_PAGE_SIZE
+		default 4096
+
+	endif # FLASH


there's no indentation on Kconfig files, just bring the block one tab back

fabiobaltieri · 2025-09-16T14:24:04Z

boards/steelseries/apex_pro_mini/Kconfig.defconfig

+	config INPUT_KBD_MATRIX_16_BIT_ROW
+		default y


since there's only one option in the if block you can change this to

default y if INPUT_GPIO_KBD_MATRIX

keep the whole thing compact, same for the flash option below

boards/steelseries/apex_pro_mini/apex_pro_mini.dts

fabiobaltieri · 2025-09-16T14:27:01Z

boards/steelseries/apex_pro_mini/apex_pro_mini.dts

+	flash1: fm25q128c@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <10000000>;


you can use DT_FREQ_M

boards/steelseries/apex_pro_mini/doc/img/apex_pro_mini.webp

boards/steelseries/apex_pro_mini/doc/index.rst

fabiobaltieri · 2025-09-16T19:56:37Z

boards/steelseries/apex_pro_mini/Kconfig.defconfig

+default y
+depends on SPI
+
+config INPUT_KBD_MATRIX_16_BIT_ROW
+default y if INPUT_GPIO_KBD_MATRIX
+
+config SPI_NOR_FLASH_LAYOUT_PAGE_SIZE
+default 4096 if FLASH


sorry I realize my comment on this was misleading :-) what I mean is that in Kconfig we don't indent the block inside the "if", not that we don't indent at all, so in this case the lines under config (deulfat y, depends on SPI`) should be indented by one tab

Look at other files maybe, I'm clearly pretty bad at explaining it

kartben · 2025-09-17T14:30:56Z

the latest push I made to the branch should fix the doc issues :)

kartben

+1 for docs!

boards/steelseries/apex_pro_mini/apex_pro_mini.dts

nordicjm · 2025-09-18T06:05:26Z

boards/steelseries/apex_pro_mini/apex_pro_mini.dts

+			, <&gpioc 2  GPIO_ACTIVE_HIGH>
+			, <&gpioc 3  GPIO_ACTIVE_HIGH>
+			;
+		keymap {


newline missing on line 69

boards/steelseries/apex_pro_mini/apex_pro_mini.dts

boards/steelseries/apex_pro_mini/apex_pro_mini_defconfig

boards/steelseries/apex_pro_mini/Kconfig.defconfig

kartben · 2025-09-19T06:09:40Z

the latest push I made to the branch should fix the doc issues :)

@everedero you need to add my earlier fix back please :)

https://github.com/zephyrproject-rtos/zephyr/compare/dfdcd043592529dbbe529bf0fc3c8fd7dbecaaf8..d270d070324c6d227beee2ad3895d26932c77582

Initial support for the Apex Pro Mini keyboard, based on STM32L412. Signed-off-by: Eve Redero <eve.redero@gmail.com>

sonarqubecloud · 2025-09-21T20:49:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kartben · 2025-09-22T09:07:58Z

Assigning to @fabiobaltieri due to this new board having a strong focus on Input subsystem stuff

nordicjm requested changes Sep 12, 2025

View reviewed changes

nordicjm reviewed Sep 12, 2025

View reviewed changes

everedero force-pushed the board/apexpromini branch 4 times, most recently from 2e7ebe0 to 72afde9 Compare September 15, 2025 09:29

zephyrbot added the area: Devicetree label Sep 15, 2025

zephyrbot requested review from decsny, mbolivar and rruuaanng September 15, 2025 09:30

zephyrbot assigned mbolivar Sep 15, 2025

everedero force-pushed the board/apexpromini branch 4 times, most recently from a18ff01 to 249117c Compare September 15, 2025 12:13

fabiobaltieri unassigned mbolivar Sep 15, 2025

fabiobaltieri self-requested a review September 15, 2025 20:11

fabiobaltieri reviewed Sep 15, 2025

View reviewed changes

everedero force-pushed the board/apexpromini branch from 249117c to 91926b4 Compare September 16, 2025 12:11

zephyrbot added the area: Flash label Sep 16, 2025

zephyrbot requested review from de-nordic and rghaddab September 16, 2025 12:12

zephyrbot assigned mbolivar Sep 16, 2025

kartben reviewed Sep 16, 2025

View reviewed changes

everedero force-pushed the board/apexpromini branch 2 times, most recently from afb72ed to 5825a2e Compare September 16, 2025 13:39

kartben reviewed Sep 16, 2025

View reviewed changes

boards/steelseries/apex_pro_mini/doc/index.rst Outdated Show resolved Hide resolved

boards/steelseries/apex_pro_mini/doc/index.rst Outdated Show resolved Hide resolved

fabiobaltieri reviewed Sep 16, 2025

View reviewed changes

everedero force-pushed the board/apexpromini branch from fe8ac99 to 38569bf Compare September 16, 2025 18:42

fabiobaltieri reviewed Sep 16, 2025

View reviewed changes

everedero force-pushed the board/apexpromini branch from 38569bf to dfdcd04 Compare September 17, 2025 10:10

fabiobaltieri previously approved these changes Sep 17, 2025

View reviewed changes

kartben dismissed fabiobaltieri’s stale review via d270d07 September 17, 2025 14:14

kartben force-pushed the board/apexpromini branch from dfdcd04 to d270d07 Compare September 17, 2025 14:14

fabiobaltieri previously approved these changes Sep 17, 2025

View reviewed changes

kartben previously approved these changes Sep 17, 2025

View reviewed changes

fabiobaltieri requested a review from nordicjm September 17, 2025 15:21

nordicjm requested changes Sep 18, 2025

View reviewed changes

everedero dismissed stale reviews from kartben and fabiobaltieri via 853fb34 September 18, 2025 09:54

everedero force-pushed the board/apexpromini branch from d270d07 to 853fb34 Compare September 18, 2025 09:54

fabiobaltieri previously approved these changes Sep 18, 2025

View reviewed changes

boards: add steelseries apex_pro_mini

1eb32b0

Initial support for the Apex Pro Mini keyboard, based on STM32L412. Signed-off-by: Eve Redero <eve.redero@gmail.com>

everedero dismissed fabiobaltieri’s stale review via 1eb32b0 September 21, 2025 20:24

everedero force-pushed the board/apexpromini branch from 853fb34 to 1eb32b0 Compare September 21, 2025 20:24

kartben approved these changes Sep 21, 2025

View reviewed changes

fabiobaltieri approved these changes Sep 22, 2025

View reviewed changes

kartben requested a review from nordicjm September 22, 2025 08:07

nordicjm approved these changes Sep 22, 2025

View reviewed changes

kartben assigned fabiobaltieri and unassigned mbolivar Sep 22, 2025

kartben merged commit 6b809c2 into zephyrproject-rtos:main Sep 22, 2025
26 checks passed

everedero deleted the board/apexpromini branch September 25, 2025 13:07

boards: add steelseries apexpromini #95905

boards: add steelseries apexpromini #95905

Uh oh!

Conversation

everedero commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nordicjm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nordicjm Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

decsny commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fabiobaltieri Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartben commented Sep 17, 2025

Uh oh!

kartben left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kartben commented Sep 19, 2025

Uh oh!

sonarqubecloud bot commented Sep 21, 2025

Quality Gate passed

Uh oh!

kartben commented Sep 22, 2025

Uh oh!

Uh oh!

Uh oh!

everedero commented Sep 12, 2025 •

edited

Loading

nordicjm Sep 15, 2025 •

edited

Loading

decsny commented Sep 15, 2025 •

edited

Loading

fabiobaltieri Sep 16, 2025 •

edited

Loading