Skip to content

Conversation

clementlgl
Copy link
Contributor

This pull request adds support for the Omron 2SMPB-02E digital barometric pressure sensor, including the driver and a sample application.

Omron 2SMPB-02E sensor driver integration:

Device tree and vendor bindings:

  • Added device tree bindings for the Omron 2SMPB-02E sensor (omron,2smpb-02e.yaml) and registered the omron vendor prefix (vendor-prefixes.txt).

Sample application and documentation:

  • Added a sample application demonstrating temperature and pressure readings from the 2SMPB-02E sensor.

Support for the OMRON 2SMPB_02E digital barometric pressure sensor.

Signed-off-by: Clément Laigle <c.laigle@catie.fr>
Added sample for the OMRON 2SMPB-02E digital barometric pressure sensor.

Signed-off-by: Clément Laigle <c.laigle@catie.fr>
Copy link

oki Oki Electric Industry Co., Ltd.
olimex OLIMEX Ltd.
olpc One Laptop Per Child
omron OMRON Corporation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nashif please help review vendor prefix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd rather have this sensor work with a generic sensor sample than having one sample per sensor, as it wouldn't scale.

I suggest looking at other tph-related samples.

bool "OMRON 2SMPB_02E digital barometric pressure sensor"
default y
depends on DT_HAS_OMRON_2SMPB_02E_ENABLED
select I2C
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If floating-point math is unavoidable, then have the sensor select the FPU.

Suggested change
select I2C
select I2C
select FPU if CPU_HAS_FPU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants