SPI: Fix deprecated API usage leftovers from #87427 #96859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delay parameter was removed from this macro, so don't pass it. Signed-off-by: Johan Hedberg <johan.hedberg@silabs.com>
Commit a60f93d removed the delay parameter from various SPI macros, but aimed to retain a clean migration path by throwing a deprecation warning when the parameter is still passed. However, the commit failed to have this feature included in the SPI_DT_IODEV_DEFINE macro. This commit should fix the issue. Signed-off-by: Johan Hedberg <johan.hedberg@silabs.com>
jhedberg
added
the
Hotfix
zephyrbot
requested review from
asemjonovs,
avisconti,
decsny,
jeppenodgaard,
MaureenHelm,
tbursztyka,
teburd,
tristan-google,
ubieda and
yperess
5 tasks
decsny
previously approved these changes
Oct 1, 2025
ubieda
previously approved these changes
Oct 1, 2025
This macro doesn't accept a delay parameter anymore (well, it does, but it's deprecated and will trigger build warnings). Just remove it from the places that were still passing it. Signed-off-by: Johan Hedberg <johan.hedberg@silabs.com>
tbursztyka
approved these changes
Oct 1, 2025
|
@jhedberg it is good now. |
ubieda
approved these changes
Oct 1, 2025
sylvioalves
approved these changes
Oct 1, 2025
zephyrbot
requested review from
henrikbrixandersen,
JarmouniA,
jfischer-no and
VynDragon
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#87427 caused some CI failures in main due some drivers still using the SPI macros in a deprecated way, and actually
SPI_DT_IODEV_DEFINE()not having the deprecation warning support. This PR tries to address both issues.